Xen devel - Jun 2008 - Re: [Xen-changelog] [xen-unstable] xentrace: fix tracing for 64bit guests

On Tue, Jun 10, 2008 at 03:40:21AM -0700, Xen patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser <keir.fraser@citrix.com>
> # Date 1213001138 -3600
> # Node ID 268a9f8286f3ae259359fb3b31197e674b8c44b8
> # Parent  5009f5d093cea2e55a3838bb7e6ee42c12b0f68a
> xentrace: fix tracing for 64bit guests
Is this an incompatible change (a brief scan made it seem so) ? If so,
it probably needs a ChangeLog entry

cheers
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/6/08 13:10, "John Levon" <levon@movementarian.org> wrote:
> On Tue, Jun 10, 2008 at 03:40:21AM -0700, Xen patchbot-unstable wrote:
> 
>> # HG changeset patch
>> # User Keir Fraser <keir.fraser@citrix.com>
>> # Date 1213001138 -3600
>> # Node ID 268a9f8286f3ae259359fb3b31197e674b8c44b8
>> # Parent  5009f5d093cea2e55a3838bb7e6ee42c12b0f68a
>> xentrace: fix tracing for 64bit guests
> 
> Is this an incompatible change (a brief scan made it seem so) ? If so,
> it probably needs a ChangeLog entry
Then so will the original patch from Andre I guess. The xentrace stuff seems
to be in fairly constant flux.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Jun 10, 2008 at 01:15:59PM +0100, Keir Fraser wrote:
> > Is this an incompatible change (a brief scan made it seem so) ? If so,
> > it probably needs a ChangeLog entry
> 
> Then so will the original patch from Andre I guess. The xentrace stuff
seems
> to be in fairly constant flux.
OK, thanks. We''ve just implemented stuff based on top of this, I
don''t
think we realised it was subject to change. We''ll keep an eye on it :)

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

John Levon wrote:
> On Tue, Jun 10, 2008 at 03:40:21AM -0700, Xen patchbot-unstable wrote:
> 
>> # HG changeset patch
>> # User Keir Fraser <keir.fraser@citrix.com>
>> # Date 1213001138 -3600
>> # Node ID 268a9f8286f3ae259359fb3b31197e674b8c44b8
>> # Parent  5009f5d093cea2e55a3838bb7e6ee42c12b0f68a
>> xentrace: fix tracing for 64bit guests
> 
> Is this an incompatible change (a brief scan made it seem so) ? If so,
> it probably needs a ChangeLog entry
It mostly adds additional tracepoints (marked by bit 8 as 64bit capable) 
and changing the CPUID trace, which was broken before (so this is more a 
fix). The user-space end of the traces is xentrace_format with the 
respective formats file, which I also changed. Otherwise I tried to be 
compatible.
Given the fact that this was broken since at least February or so, I 
don''t think that anyone seriously uses tracing and could be concerned 
about such changes. There are still some tracepoints logged but not 
interpreted by xentrace_format, I will send a patch later.

BTW: Has anyone tools for analyzing traces? Does someone use tracing 
regularly?


Regards,
Andre.

-- 
Andre Przywara
AMD-OSRC (Dresden)
Tel: x84917


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Jun 10, 2008 at 02:28:05PM +0200, Andre Przywara wrote:
> >Is this an incompatible change (a brief scan made it seem so) ? If so,
> >it probably needs a ChangeLog entry
> It mostly adds additional tracepoints (marked by bit 8 as 64bit capable) 
> and changing the CPUID trace, which was broken before (so this is more a 
> fix). The user-space end of the traces is xentrace_format with the 
> respective formats file, which I also changed. Otherwise I tried to be 
> compatible.
That''s fine, but it would be good to track things that change. We have
stuff on top of this (though I don''t think we care about the particular
changes you''ve made, yet).

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel