Xen devel - Jun 2008 - [Patch] XendOptionsSMF, missing get_config_value method on Solaris

Hi,

On Solaris, xend XendOptions.py uses an additional interface XendOptionsSMF.
This allows xend configuration via Solaris SMF as well as the config file.
(Added by changeset 13407).

Problem: XendOptionsSMF doesn''t define a get_config_value; but these
is get_config_string.  The code in XendOptions.py needs both; 
get_keymap() needs get_config_value.

The attached patch adds the missing get_config_value to interface
XendOptionsSMF.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Jun 06, 2008 at 02:57:13PM +0200, Juergen Keil wrote:
> On Solaris, xend XendOptions.py uses an additional interface
XendOptionsSMF.
> This allows xend configuration via Solaris SMF as well as the config file.
> (Added by changeset 13407).
> 
> Problem: XendOptionsSMF doesn''t define a get_config_value; but
these
> is get_config_string.  The code in XendOptions.py needs both; 
> get_keymap() needs get_config_value.
I''m not sure about this: SMF values are always typed and
there''s really
no such thing as just a value. Instead, I think get_keymap() needs to
use get_config_string(). Note it''s the only base class routine that
does
this.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

John Levon wrote:
> On Fri, Jun 06, 2008 at 02:57:13PM +0200, Juergen Keil wrote:
> 
> > On Solaris, xend XendOptions.py uses an additional interface
XendOptionsSMF.
> > This allows xend configuration via Solaris SMF as well as the config
file.
> > (Added by changeset 13407).
> > 
> > Problem: XendOptionsSMF doesn''t define a get_config_value;
but these
> > is get_config_string.  The code in XendOptions.py needs both; 
> > get_keymap() needs get_config_value.
> 
> I''m not sure about this: SMF values are always typed and
there''s really
> no such thing as just a value. Instead, I think get_keymap() needs to
> use get_config_string(). Note it''s the only base class routine
that does
> this.
Ok, changing the base class to use get_config_string instead of 
of get_config_value would be another way to fix this.
> Note it''s the only base class routine that does this.
In xen-unstable, there also is get_resource_label_change_script().


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

John Levon wrote:
> Instead, I think get_keymap() needs to use get_config_string().
Here''s an alternate version of my previous patch,
using get_config_string for options that are strings.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel