Xen devel - Jan 2007 - [PATCH] the address of ''symbols_addresses'' will always evaluate as ''true''

Hi;

Attached patch adds "-Wno-always-true" CFLAGS into
xen/arch/powerpc/Rules.mk
and xen/arch/x86/Rules.mk, else compiling xen with latest gcc-4.2.0 snapshot 
fails, patch is against current xen-3.0.4-testing repo;

make[3]: Entering directory 
`/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/common''
gcc -O2 -fomit-frame-pointer -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -nostdinc
-fno-builtin -fno-common -fno-strict-aliasing -iwithprefix
include -Werror -Wno-pointer-arith -pipe
-I/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/include
-I/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/include/asm-x86/mach-generic
-I/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -g -D__XEN__ -c
symbols.c -o symbols.o
cc1: warnings being treated as errors
symbols.c: In function ''symbols_lookup'':
symbols.c:97: warning: the address of ''symbols_addresses'' will
always evaluate
as ''true''
make[3]: *** [symbols.o] Error 1
make[3]: Leaving directory 
`/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/common''
make[2]: *** 
[/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/common/built_in.o] 
Error 2
make[2]: Leaving directory 
`/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/arch/x86''
make[1]: *** [/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen/xen] Error 
2
make[1]: Leaving directory 
`/var/pisi/xen-3.0.4.1-3/work/xen-3.0.4-testing.hg/xen''
make: *** [build] Error 2

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/1/07 01:18, "S.Çağlar Onur" <caglar@pardus.org.tr> wrote:
> Attached patch adds "-Wno-always-true" CFLAGS into
xen/arch/powerpc/Rules.mk
> and xen/arch/x86/Rules.mk, else compiling xen with latest gcc-4.2.0
snapshot
> fails, patch is against current xen-3.0.4-testing repo;
If that is the *only* build error, then we can just get rid of that
BUG_ON(). It doesn''t work any more anyway (that symbol is never zero,
even
during initial kernel link when no symbol info is available).
BUG_ON(symbols_num_syms == 0) is probably the right replacement.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

10 Oca 2007 Çar 12:31 tarihinde, Keir Fraser şunları yazmıştı:
> If that is the *only* build error, then we can just get rid of that
> BUG_ON(). It doesn''t work any more anyway (that symbol is never
zero, even
> during initial kernel link when no symbol info is available).
> BUG_ON(symbols_num_syms == 0) is probably the right replacement.
Yes this is the only build error so modified patch attached, tested on x86.

Chers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel