Jan Beulich
2006-Jun-01 12:35 UTC
[Xen-devel] [PATCH] x86_64: properly update RSI/RDI after emulated ins/outs (again)
Unfortunately, the previous patch to address this wasn''t taken unmodified, and the modification (c/s 10171, including most of the additions over the original patch) made the changes useless - the conditional operator yields unsigned if either of the operands is unsigned and the other is signed. Signed-off-by: Jan Beulich <jbeulich@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jun-01 13:03 UTC
Re: [Xen-devel] [PATCH] x86_64: properly update RSI/RDI after emulated ins/outs (again)
On 1 Jun 2006, at 13:35, Jan Beulich wrote:> Unfortunately, the previous patch to address this wasn''t taken > unmodified, and the modification (c/s 10171, including > most of the additions over the original patch) made the changes > useless - the conditional operator yields unsigned if > either of the operands is unsigned and the other is signed.Maybe we should just make the variable a signed type to start with, or hide this behind a macro. It does crop up in quite a few places. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel