Xapian discuss - Feb 2009 - Ticket #282: omindex-assorted-enhancements.patch woes

I would really like to try out the features in the patch above.  But I
can't ever seem to get the resulting omindex.cc to "make".

I tried updating to rev 10801 from the SVN then run /bootstrap but then
I seem to get errors compiling everything when I try and do "make"
(I'm
using ubuntu 8.10).

So I thought I'd try an apply the patch to the latest stable version
1.0.10.  The patch created a reject file but I edited in the two lines
it rejected myself.

But when I run "make" I get the following errors:

omindex.o: In function `main':
/home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:874: undefined
reference to `read_config_file()'
/home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:987: undefined
reference to `log_dir'
collect2: ld returned 1 exit status

Could anyone suggest what I've dome wrong?




FYI Here's the reject file:

***************
*** 397,406 ****
      } else if (mimetype == "text/rtf") {
  	// The --text option unhelpfully converts all non-ASCII characters to
  	// "?" so we use --html instead, which produces HTML entities.
- 	string cmd = "unrtf --nopict --html 2>/dev/null " +
shell_protect(file);
  	MyHtmlParser p;
  	try {
- 	    p.parse_html(stdout_to_string(cmd));
  	} catch (ReadError) {
  	    cout << "\"" << cmd << "\"
failed - skipping\n";
  	    return;
--- 426,435 ----
      } else if (mimetype == "text/rtf") {
  	// The --text option unhelpfully converts all non-ASCII characters to
  	// "?" so we use --html instead, which produces HTML entities.
+ 	string cmd = "unrtf --nopict --html " + shell_protect(file);
  	MyHtmlParser p;
  	try {
+ 	    p.parse_html(run_cmd(cmd));
  	} catch (ReadError) {
  	    cout << "\"" << cmd << "\"
failed - skipping\n";
  	    return;

On Mon, Feb 02, 2009 at 11:53:45PM +1030, Frank John Bruzzaniti wrote:
> I would really like to try out the features in the patch above.  But I
> can't ever seem to get the resulting omindex.cc to "make".
> 
> I tried updating to rev 10801 from the SVN then run /bootstrap but then
> I seem to get errors compiling everything when I try and do
"make" (I'm
> using ubuntu 8.10).
Without some idea of the errors, we probably can't help on this. Does
it compile without the patch?
> So I thought I'd try an apply the patch to the latest stable version
> 1.0.10.  The patch created a reject file but I edited in the two lines
> it rejected myself.
Okay.
> But when I run "make" I get the following errors:
> 
> omindex.o: In function `main':
> /home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:874: undefined
> reference to `read_config_file()'
> /home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:987: undefined
> reference to `log_dir'
> collect2: ld returned 1 exit status
> 
> Could anyone suggest what I've dome wrong?
Looks like that target will need configfile.o as well, although I
haven't been paying attention so I may be missing something.

J

-- 
  James Aylett

  talktorex.co.uk - xapian.org - uncertaintydivision.org

On Mon, Feb 02, 2009 at 11:53:45PM +1030, Frank John Bruzzaniti
wrote:
> But when I run "make" I get the following errors:
> 
> omindex.o: In function `main':
> /home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:874: undefined
> reference to `read_config_file()'
> /home/frankie/Desktop/xapian-omega-1.0.10/omindex.cc:987: undefined
> reference to `log_dir'
> collect2: ld returned 1 exit status
> 
> Could anyone suggest what I've dome wrong?
The patch modifies Makefile.am but it looks like you didn't configure
omega with "--enable-maintainer-mode".

Cheers,
    Olly