On Mon, May 30, 2016 at 04:35:15PM +0100, James Aylett wrote:> 7. In configure.ac, you should default to xapian-config, not > xapian-config-1.3; anyone who's using a development version can point > XAPIAN_CONFIG to the relevant binary. It isn't a huge issue right now > (since you're not targetting Xapian 1.2), but 1.4 should be out during > the course of GSoC, and we'll want RXapian to support that without > people having to do anything special.It would be better to use the XO_LIB_XAPIAN macro provided by xapian-core instead of writing your own code to probe for xapian-config. Everything from line 3 to line 18 of your current configure.ac could be replaced with just: XO_LIB_XAPIAN If you've installed xapian-core then the macro should just be found automatically. If you want to build against an uninstalled xapian-core, you need to pass -I options to aclocal so it can find the macro (the top level `bootstrap` does this automatically - at some point we should probably sort out support for RXapian in there). Cheers, Olly
i Olly, Everything from line 3 to line 18 of your current configure.ac could be> replaced with just: > > XO_LIB_XAPIAN > > If you've installed xapian-core then the macro should just be > found automatically. >When I replace the code block with the macro, it doesn't get automatically detected. Could you kindly tell me what could be causing this? at some point> we should probably sort out support for RXapian in there >I don't understand why this needs to be done. Shouldn't the source code of RXapian be kept separately and distributed via CRAN? Best regards, Amanda -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xapian.org/pipermail/xapian-devel/attachments/20160618/1b9a2771/attachment.html>
On Sat, Jun 18, 2016 at 07:10:43PM +0530, Amanda Jayanetti wrote:> > If you've installed xapian-core then the macro should just be > > found automatically. > > When I replace the code block with the macro, it doesn't get automatically > detected. Could you kindly tell me what could be causing this?You probably need to specify XAPIAN_CONFIG: $ ./configure XAPIAN_CONFIG=path/to/xapian-config-1.3 (This is because development versions of Xapian have the -1.x suffix, but the macro looks for just xapian-config by default -- which is what most people want, as they'll be using release versions of Xapian.)> > at some point > > we should probably sort out support for RXapian in there > > I don't understand why this needs to be done. Shouldn't the source code of > RXapian be kept separately and distributed via CRAN?How does putting code in CRAN work? Do you build a tgz or similar? (In which case what we probably want is to have a script that does that, and we can have RXapian in the main repo, which would make it easier for us to run automated tests (or at least automated builds) for the latest versions. J -- James Aylett, occasional trouble-maker xapian.org