Xapian devel - Mar 2014 - some errors

Hi,


Today I build latest xapian from git, and find some errors.
For example, in xapian-core/api/valueiterator.cc, Line 141,



bool

ValueIterator::check(Xapian::docid did)

{

    LOGCALL(API, bool, "ValueIterator::check", did);

    if (internal) {

    if (!internal->check(did)) return false;

    if (internal->at_end()) {

        decref();

        internal = NULL;

    }

    }

    return true;

}





LOGCALL is used, so we should use RETURN rather than return.
Because of the use of "return", my complier give a warning 


typedef 'xapian_logcall_return_type_' locally defined but not used
[-Werror=unused-local-typedefs]      typedef TYPE xapian_logcall_return_type_; \


which is regarded as an error, so I can get it built.


And it seems there are lots of same errors, e.g. in omdatabase.cc, Line 126
omdocument.cc, omenquire.cc, queryinternal.cc ....and so on...
 




------------------
Shangtong Zhang,Second Year Undergraduate,
School of Computer Science,
Fudan University, China.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xapian.org/pipermail/xapian-devel/attachments/20140306/8e21e719/attachment-0002.html>

On Thu, Mar 06, 2014 at 05:31:54PM +0800, Hurricane Tong
wrote:
> LOGCALL is used, so we should use RETURN rather than return.
> Because of the use of "return", my complier give a warning 
> 
> typedef 'xapian_logcall_return_type_' locally defined but not used
[-Werror=unused-local-typedefs]      typedef TYPE xapian_logcall_return_type_; \
This code hasn't changed recently, so I am guessing you've either
changed compiler (to clang or a recent GCC I suspect) or reran configure
with --enable-log since your previous builds?

Either way, patches to fix warnings are always welcome.  As you say, we
should be using the RETURN macro here, which will both avoid the warning
and mean the log can report the value returned.

Cheers,
    Olly