Hi, apparently there have been some issues with using ov_fopen() on win32. Does anyone have more information about this? There is no bug listed in trac.xiph.org but it has come up on IRC. Just now a user Xelaie reported "undefined reference to `ov_fopen'", building with gcc in Visual Studio, using vorbis from http://www.xiph.org/downloads/. It turned out that ov_fopen was not listed in vorbis/win32/vorbisfile.def. After adding that and rebuilding libvorbisfile, linking worked. Are there any other issues here, ie. was ov_fopen left out of the .def file on purpose (due to incompatibilites with win32 stdio or whatever)? Conrad.
On Mon, Dec 8, 2008 at 12:51 AM, Conrad Parker <conrad at metadecks.org> wrote:> Are there any other issues here, ie. was ov_fopen left out of the .def > file on purpose (due to incompatibilites > with win32 stdio or whatever)?It looks like ov_fopen() was added when ov_open() became deprecated because of the runtime conflicts with passing a FILE* through the API on win32. Probably leaving it out of the .def file was just an oversight. Please commit the addition. -r
2008/12/8 Ralph Giles <giles at xiph.org>:> On Mon, Dec 8, 2008 at 12:51 AM, Conrad Parker <conrad at metadecks.org> wrote: > >> Are there any other issues here, ie. was ov_fopen left out of the .def >> file on purpose (due to incompatibilites >> with win32 stdio or whatever)? > > It looks like ov_fopen() was added when ov_open() became deprecated > because of the runtime conflicts with passing a FILE* through the API > on win32. Probably leaving it out of the .def file was just an > oversight. Please commit the addition. >ok done, r15566 K.