Erik de Castro Lopo
2008-May-03 22:44 UTC
[Vorbis-dev] Cross compiling Linux -> windows has broken
Hi all, SOme of the recent changes to the build system has broken Linux to windows cross compile. I'm currently trying to fix that and found that configure.ac has a redundant check. This patch fixes it: ------8<------8<------8<------8<------8<------8<------8<------8<------ --- configure.ac (revision 14830) +++ configure.ac (working copy) @@ -203,13 +203,7 @@ AC_CHECK_LIB(pthread, pthread_create, pthread_lib="-lpthread", :) HAVE_OGG=no -dnl first check through pkg-config -dnl check for pkg-config itself so we don't try the m4 macro without pkg-config -AC_CHECK_PROG(HAVE_PKG_CONFIG, pkg-config, yes) -if test "x$HAVE_PKG_CONFIG" = "xyes" -then - PKG_CHECK_MODULES(OGG, ogg >= 1.0, HAVE_OGG=yes, HAVE_OGG=no) -fi +PKG_CHECK_MODULES(OGG, ogg >= 1.0, HAVE_OGG=yes, HAVE_OGG=no) if test "x$HAVE_OGG" = "xno" then dnl fall back to the old school test ------8<------8<------8<------8<------8<------8<------8<------8<------ Basically the issue is that the PKG_CHECK_MODULES already checks for pkg-config and secondly, when cross compiling, the actual pkg-config is not used, instead it looks for <cross-compiler>-pkg-config where for Linux -> windows <cross-compiler> is i586-mingw32msvc which is a wrapper script around the standard pkg-config. Ok, if I apply the above patch? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "I wouldn't want to create the impression that I wouldn't like the government of the United States to be Islamic sometime in the future." -- Ibrahim Hooper, spokesman for Council of American Islamic Relations.
Ralph Giles
2008-May-03 23:07 UTC
[Vorbis-dev] Cross compiling Linux -> windows has broken
On 3-May-08, at 3:44 PM, Erik de Castro Lopo wrote:> SOme of the recent changes to the build system has broken Linux > to windows cross compile. I'm currently trying to fix that and > found that configure.ac has a redundant check.The check for pkg-config seems to do nothing useful at this point. Patch is fine with me. -r