Vorbis dev - Jan 2008 - vorbis-tools 1.2.0 Release Candidate

I bumped the version number of vorbis-tools and am preparing it for an
eventual release in a few days.

A changelog of what's new may be found at [1].

Meanwhile, what's in SVN is a "Release Candidate" to find out if
anything was broken since version 1.1.1.  Report any (or lack of)
problems you may find, so we'll be able to put out a new version of
vorbis-tools.

-Ivo

[1] https://svn.xiph.org/trunk/vorbis-tools/CHANGES

On 1/25/2008 9:58 AM, Ivo Emanuel Gon?alves wrote:
> I bumped the version number of vorbis-tools and am preparing it for an
> eventual release in a few days.
> 
> A changelog of what's new may be found at [1].
> 
> Meanwhile, what's in SVN is a "Release Candidate" to find out
if
> anything was broken since version 1.1.1.  Report any (or lack of)
> problems you may find, so we'll be able to put out a new version of
> vorbis-tools.
I needed to apply the attached patch to compile r14433 for Cygwin. 
Otherwise, everything worked fine.

-- 
David Rothenberger  ----  daveroth@acm.org

-------------- next part --------------
diff -urN -x CYGWIN-PATCHES -x 'aclocal.m4*' -x ltmain.sh -x
'config.*' -x depcomp -x install-sh -x missing -x mkinstalldirs -x
autom4te.cache -x '*compile' -x Makefile.in.in -x 'intltool*.in'
-x 'xml-i18n-*.in' -x '*.pyc' -x '*.mo' -x
'*.gmo' -x ABOUT-NLS -x Makevars.template -x COPYING -x INSTALL -x
mdate-sh -x '*.orig' -x '*.rej' -x '*~' -x
'*.temp' -x texinfo.tex -x ylwrap -x Makefile.in -x makefile.in -x
configure -x gnome-doc-utils.make -x gnome-doc-utils.m4 -x intltool.m4 -x
omf.make -x xmldocs.make origsrc/vorbis-tools/oggdec/Makefile.am
src/vorbis-tools/oggdec/Makefile.am
--- origsrc/vorbis-tools/oggdec/Makefile.am	2008-01-26 12:40:26.000000000 -0800
+++ src/vorbis-tools/oggdec/Makefile.am	2008-01-26 12:55:21.696250000 -0800
@@ -11,7 +11,7 @@
 
 INCLUDES = @OGG_CFLAGS@ @VORBIS_CFLAGS@ @SHARE_CFLAGS@
 
-oggdec_LDADD = @LIBICONV@ @SHARE_LIBS@ @VORBISFILE_LIBS@ @VORBIS_LIBS@
@OGG_LIBS@
+oggdec_LDADD = @LIBICONV@ @SHARE_LIBS@ @VORBISFILE_LIBS@ @VORBIS_LIBS@
@OGG_LIBS@ @I18N_LIBS@
 oggdec_DEPENDENCIES = @SHARE_LIBS@
 
 oggdec_SOURCES = $(oggdecsources)

On 1/26/08, David Rothenberger <daveroth@acm.org>
wrote:
> I needed to apply the attached patch to compile r14433 for Cygwin.
> Otherwise, everything worked fine.
Did you not need this @I18N_LIBS@ flag on 1.1.1?  I wonder what
changed that requires it now.  The .po translation stuff was already
there in 1.1.1.  Or is this something needed for proper display of
Unicode?

On 1/26/2008 9:22 PM, Ivo Emanuel Gon?alves wrote:
> On 1/26/08, David Rothenberger <daveroth@acm.org> wrote:
>> I needed to apply the attached patch to compile r14433 for Cygwin.
>> Otherwise, everything worked fine.
> 
> Did you not need this @I18N_LIBS@ flag on 1.1.1?  
No.
> I wonder what changed that requires it now.
#include "i18n.h" was added
> The .po translation stuff was already there in 1.1.1. Or is this
> something needed for proper display of Unicode?
Was the .po translation stuff used in oggdec?

-- 
David Rothenberger  ----  daveroth@acm.org

God requireth not a uniformity of religion.
                 -- Roger Williams

Ivo Emanuel Gon?alves <justivo@gmail.com> wrote:
> Third and hopefully final Release Candidate is out[1].
Why is vcut disabled by default?

The path of ogg123rc is still hard-coded to /etc.  This should
really be $(sysconfdir).

--- ogg123/Makefile.am.orig	Fri Mar 16 16:50:58 2007
+++ ogg123/Makefile.am	Fri Mar 16 16:52:04 2007
@@ -16,7 +16,7 @@ endif
 
 datadir = @datadir@
 localedir = $(datadir)/locale
-DEFS = -DLOCALEDIR=\"$(localedir)\" @DEFS@
+DEFS = -DSYSCONFDIR=\"$(sysconfdir)\"
-DLOCALEDIR=\"$(localedir)\" @DEFS@
 
 docdir = $(datadir)/doc/$(PACKAGE)-$(VERSION)
 mandir = @MANDIR@
--- ogg123/cfgfile_options.c.orig	2003-09-30 02:15:22.000000000 +0200
+++ ogg123/cfgfile_options.c	2003-09-30 02:15:39.000000000 +0200
@@ -441,7 +441,7 @@ void parse_std_configs (file_option_t op
   char filename[FILENAME_MAX];
   char *homedir = getenv("HOME");
 
-  parse_config_file(opts, "/etc/ogg123rc");
+  parse_config_file(opts, SYSCONFDIR "/ogg123rc");
   if (homedir && strlen(homedir) < FILENAME_MAX - 10) {
     /* Try ~/.ogg123 */
     strncpy(filename, homedir, FILENAME_MAX);
-- 
Christian "naddy" Weisgerber                         
naddy@mips.inka.de

Ivo Emanuel Gon?alves <justivo@gmail.com> wrote:
> Third and hopefully final Release Candidate is out[1].
There is a 64/32-bit screw-up in the ogg123 options parsing on LP64
platforms.

cfgfile_options.c expects opt_type_bool and opt_type_int settings
to be stored in long int variables.  However, ogg123.c:file_opts[]
points to options.shuffle and options.repeat, which are defined as
int in ogg123.h.  This means 64-bit values are written to 32-bit
variables, which--depending on the specifics of the platform regarding
endianness and strict alignment--can lead to garbage settings or a
fatal address error.  (E.g., on sparc64, ogg123 immediately dumps
core.)

The easiest fix is to bump the options.shuffle and .repeat variables up
to type long int.

--- ogg123/ogg123.h.orig	Sun Feb 10 19:32:19 2008
+++ ogg123/ogg123.h	Sun Feb 10 19:32:36 2008
@@ -25,8 +25,8 @@
 typedef struct ogg123_options_t {
   long int verbosity;         /* Verbose output if > 1, quiet if 0 */
 
-  int shuffle;                /* Should we shuffle playing? */
-  int repeat;                 /* Repeat playlist indefinitely? */
+  long int shuffle;           /* Should we shuffle playing? */
+  long int repeat;            /* Repeat playlist indefinitely? */
   ogg_int64_t delay;          /* delay (in millisecs) for skip to next song */
   int nth;                    /* Play every nth chunk */
   int ntimes;                 /* Play every chunk n times */
-- 
Christian "naddy" Weisgerber                         
naddy@mips.inka.de

On 2/10/08, Christian Weisgerber <naddy@mips.inka.de>
wrote:
> The easiest fix is to bump the options.shuffle and .repeat variables up
> to type long int.
I committed this change but it met resistance[1].  Would you perhaps
propose another solution around this issue?

-Ivo

[1] http://lists.xiph.org/pipermail/vorbis-dev/2008-February/019184.html

Christian, Ivo,

Could you review/test this patch in the other direction?

  -r

-------------- next part --------------
A non-text attachment was scrubbed...
Name: longfix.diff
Type: application/octet-stream
Size: 2601 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080211/e786c9de/longfix.obj