Gene Pavlovsky
2005-Sep-27 01:44 UTC
[Vorbis-dev] vorbiscomment, ogg123 charset bug - ticket #685
Hi I've a bug in vorbis-tools's libutf8 - some share/*.[ch] files don't include config.h; as a result, utf8.c:convert_set_charset doesn't try charset = nl_langinfo(CODESET) which would correctly return UTF-8, because HAVE_LANGINFO_CODESET isn't defined (it's defined in config.h, but config.h is not included). So, the bugfix is simple - just include config.h everywhere where it's missing. -- The human knowledge belongs to the world
Conrad Parker
2005-Sep-27 03:18 UTC
[Vorbis-dev] vorbiscomment, ogg123 charset bug - ticket #685
On Mon, Sep 26, 2005 at 12:36:09PM +0400, Gene Pavlovsky wrote:> Hi > > I've a bug in vorbis-tools's libutf8 - some share/*.[ch] files don't include config.h; as a result, utf8.c:convert_set_charset doesn't try charset = nl_langinfo(CODESET) which would correctly return UTF-8, because HAVE_LANGINFO_CODESET isn't defined (it's defined in config.h, but config.h is not included). So, the bugfix is simple - just include config.h everywhere where it's missing. >do you have a patch? (it's probably faster to apply and test a patch than to replicate your work :-) Conrad.
Conrad Parker
2005-Sep-27 08:35 UTC
[Vorbis-dev] vorbiscomment, ogg123 charset bug - ticket #685
On Tue, Sep 27, 2005 at 03:32:10PM +0400, Gene Pavlovsky wrote:> here it is. i test it this way. i don't have CHARSET set, my LC_CTYPE=ru_RU.UTF-8 > i run vorbiscomment -w -t 'something=???????' (something=RUSSIAN in russian) test.ogg (where test.ogg is an existing file), > the vorbiscomment -l test.ogg; ogginfo test.ogg; everything works - i see russian characters. unpatched version yields '#' instead of them.excellent, I've tested this with some Japanese comments also and it works ok (and vorbiscomment failed before applying the patch). Patch applied to svn (changeset:10080) and I've closed the bug, thanks!! Conrad.
Maybe Matching Threads
- UTF-8 stuff
- [patch] R-1.9.0: compile error without nl_langinfo(CODESET) (PR#6789)
- ogginfo: playlength display in milliseconds
- using vorbiscomments with metaflac not utf8-encoded
- Bug#785187: Bug#785187: xen-hypervisor-4.5-amd64: Option ucode=scan is not working