Vorbis dev - Mar 2002 - Bug in ogglib leads to incomplete packets

There seems to be a bug in ogg lib:

The error occurs in the following situation:

- You have called ogg_stream_reset
- You deliver a page to the stream which contains
  only the "middle of packet. I.e. not the beginning
  and not the end.
  (packets = 0         continued = 1)
- You deliver the next page which contains
  the end of the page before and some more
  (packets >= 1 )

Now ogglib returns the end of this packet as
a complete packet because the check if there
was a hole is only done once in ogg_stream_pagein

Best regards,
Tobias

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Mon, Mar 18, 2002 at 10:33:08PM +0100, tobias.waldvogel@realtech.de
wrote:
> There seems to be a bug in ogg lib:
> 
> The error occurs in the following situation:
> 
> - You have called ogg_stream_reset
> - You deliver a page to the stream which contains
>   only the "middle of packet. I.e. not the beginning
>   and not the end.
>   (packets = 0         continued = 1)
> - You deliver the next page which contains
>   the end of the page before and some more
>   (packets >= 1 )
> 
> Now ogglib returns the end of this packet as
> a complete packet because the check if there
> was a hole is only done once in ogg_stream_pagein
That behavior would indeed be a bug.  Do you have an example stream
that causes it?

[This case is tested in the framing unit tests, although it's possible
the test is not complete enough]

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.