Vorbis dev - Jul 2001 - AGAIN: ogg123/ogg123.c of vorbis-tools causes error on FreeBSD

In the vorbis-tools of the 20010710 version of CVS snapshot,
ogg123/ogg123.c causes error on FreeBSD: <sys/types.h> is required.
This *HAS NOT BEEN FIXED SINCE THE 20010601 VERSION*.
I would appreciate if you just add an #include line - or let me know
why you do not want to do so.

// Kenji Rikitake

*** ogg123.c.FCS	Sun Apr  8 11:33:08 2001
--- ogg123.c	Sat Jun  2 00:40:08 2001
***************
*** 26,27 ****
--- 26,28 ----
  #include <netdb.h>
+ #include <sys/types.h>
  #include <netinet/in.h>

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Wed, Jul 11, 2001 at 04:52:46PM +0900, Kenji Rikitake
wrote:
> In the vorbis-tools of the 20010710 version of CVS snapshot,
> ogg123/ogg123.c causes error on FreeBSD: <sys/types.h> is required.
> This *HAS NOT BEEN FIXED SINCE THE 20010601 VERSION*.
> I would appreciate if you just add an #include line - or let me know
> why you do not want to do so.
The simple problem is that addition of 
> + #include <sys/types.h>
breaks other systems that do not have this file.  We'll fix it... but
we can't accept a patch that has only been thought about for a single
platform!  The real fix takes more work.

To be sure it stays in front of our noses and is not forgotten, filing
a bug report at bugs.xiph.org would be the best course of action.
That's the real bug list that gets attention.

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.