Vorbis dev - Nov 2000 - vorbis module: Makefile cleaning

should tone barkmel and psytune be in vorbis or vorbis-tools?
and if you're going to leave them around, perhaps put in the compilation
rules as something like:
--- vorbis/lib/Makefile.am
EXTRA_PROGRAMS = psytune barkmel tone
CLEANFILES = psytune barkmel tone
psytune_SOURCES = psytune.c
psytune_LDADD = .libs/libvorbis.a
barkmel_SOURCES = barkmel.c
tone_SOURCES = tone.c
--- rather than just plopping them into EXTRA_DIST
(this way they don't get made by default, but the compilation rule is there)

oh yah.  psytune.c should now include "backends.h" at the beginning,
and
there are two lines where the frameno --> granulepos name change was missed.

Similarly, it might be an idea to reinstate the 'selftest' target, even
though
you normally wouldn't make it.

I also have rules to make the special library versions
e.g. --- vorbis/Makefile.am with
train_lsp:
        $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP"
analysis:
        $(MAKE) all CFLAGS="@CFLAGS@ -DANALYSIS"
both:
        $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP -DANALYSIS"
--- targets.   This is a minimal change, and there are certainly better
    ways to do it  (i.e. a separate libname for specialized oggenc versions
    that pick up the statistics-gathering versions of the libs.  The specialized
    libs should probably be statically linked, and never installed, just getting
    used for the specialized oggenc versions

Heh and wouldn't it be nice to support --program-prefix and friends so that
one
could switch easily between 'stable' and 'development' binaries?

Just some ideas for beta3 niceties (as if you didn't have enough),
Erik

If such hacker niceties are desired I can help someone put'em in place.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

> psytune_LDADD = .libs/libvorbis.a
this was added (i modified it though) but just wanted to let you know that
this is not the correct thing to do :)

it should be:

psytune_LDFLAGS = -static
psytune_LDADD = libvorbis.la
> oh yah.  psytune.c should now include "backends.h" at the
beginning, and
> there are two lines where the frameno --> granulepos name change was
missed.
done.
> Similarly, it might be an idea to reinstate the 'selftest' target,
even though
> you normally wouldn't make it.
> 
> I also have rules to make the special library versions
> e.g. --- vorbis/Makefile.am with
> train_lsp:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP"
> analysis:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DANALYSIS"
> both:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP -DANALYSIS"
I'll wait for monty's thoughts on this one.  I suggested this before and
he told me not to do it :)
> Heh and wouldn't it be nice to support --program-prefix and friends so
that one
> could switch easily between 'stable' and 'development'
binaries?
That's already supported silly.  --with-ogg-prefix --with-vorbis-prefix
--with-ao-prefix is all supported.
> Just some ideas for beta3 niceties (as if you didn't have enough),
thanks :)

jack.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.