Christoph Hellwig
2022-Dec-07 16:31 UTC
[PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
On Wed, Dec 07, 2022 at 05:21:48AM -0500, Michael S. Tsirkin wrote:> Christoph you acked the spec patch adding this to virtio blk: > > Still not a fan of the encoding, but at least it is properly documented > now: > > Acked-by: Christoph Hellwig <hch at lst.de> > > Did you change your mind then? Or do you prefer a different encoding for > the ioctl then? could you help sugesting what kind?Well, it is good enough documented for a spec. I don't think it is a useful feature for Linux where virtio-blk is our minimum viable paravirtualized block driver.
Michael S. Tsirkin
2022-Dec-07 20:28 UTC
[PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
On Wed, Dec 07, 2022 at 08:31:28AM -0800, Christoph Hellwig wrote:> On Wed, Dec 07, 2022 at 05:21:48AM -0500, Michael S. Tsirkin wrote: > > Christoph you acked the spec patch adding this to virtio blk: > > > > Still not a fan of the encoding, but at least it is properly documented > > now: > > > > Acked-by: Christoph Hellwig <hch at lst.de> > > > > Did you change your mind then? Or do you prefer a different encoding for > > the ioctl then? could you help sugesting what kind? > > Well, it is good enough documented for a spec. I don't think it is > a useful feature for Linux where virtio-blk is our minimum viable > paravirtualized block driver.No idea what this means, sorry. Now that's in the spec I expect (some) devices to implement it and if they do I see no reason not to expose the data to userspace. Alvaro could you pls explain the use-case? Christoph has doubts that it's useful. Do you have a device implementing this? -- MST