Christoph Hellwig
2022-Dec-07 07:35 UTC
[PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
This just seems like a horrible interface. And virtio-blk should be a simple passthrough and not grow tons of side-band crap like this. If you want to pass through random misc information use virtio-scsi or nvme with shadow doorbell buffers.
Michael S. Tsirkin
2022-Dec-07 10:21 UTC
[PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
On Tue, Dec 06, 2022 at 11:35:31PM -0800, Christoph Hellwig wrote:> This just seems like a horrible interface. And virtio-blk should be > a simple passthrough and not grow tons of side-band crap like this. > > If you want to pass through random misc information use virtio-scsi > or nvme with shadow doorbell buffers.Christoph you acked the spec patch adding this to virtio blk: Still not a fan of the encoding, but at least it is properly documented now: Acked-by: Christoph Hellwig <hch at lst.de> Did you change your mind then? Or do you prefer a different encoding for the ioctl then? could you help sugesting what kind? Thanks, -- MST