On Tue, Dec 6, 2022 at 12:55 AM Alvaro Karsz <alvaro.karsz at
solid-run.com> wrote:>
> > We must send a SNET_MSG_DESTROY message to the DPU before removing
the device.
> > This remove() makes sure that if somehow remove was called
> > before/without reset, the DPU will receive this message.
>
> I meant that the message must be sent before the PCI device is removed.
> The message is sent from the vDPA reset cb, and the reset in the PCI
> remove cb makes sure that PCI remove wasn't called without calling
> vDPA reset.
> I can remove it if you think that this is not required.
The reset is usually done during probe:
E.g register_virtio_device() or vhost_vdpa_open().
If it's not required, let's remove but if it is a must for your
hardware, we need keep it.
Thanks
>
>
> Alvaro
>