Robin Murphy
2022-Sep-14 19:53 UTC
[PATCH 4/5] iommu: Regulate errno in ->attach_dev callback functions
On 2022-09-14 18:58, Nicolin Chen wrote:> On Wed, Sep 14, 2022 at 10:49:42AM +0100, Jean-Philippe Brucker wrote: >> External email: Use caution opening links or attachments >> >> >> On Wed, Sep 14, 2022 at 06:11:06AM -0300, Jason Gunthorpe wrote: >>> On Tue, Sep 13, 2022 at 01:27:03PM +0100, Jean-Philippe Brucker wrote: >>>> I think in the future it will be too easy to forget about the constrained >>>> return value of attach() while modifying some other part of the driver, >>>> and let an external helper return EINVAL. So I'd rather not propagate ret >>>> from outside of viommu_domain_attach() and finalise(). >>> >>> Fortunately, if -EINVAL is wrongly returned it only creates an >>> inefficiency, not a functional problem. So we do not need to be >>> precise here. >> >> Ah fair. In that case the attach_dev() documentation should indicate that >> EINVAL is a hint, so that callers don't rely on it (currently words "must" >> and "exclusively" indicate that returning EINVAL for anything other than >> device-domain incompatibility is unacceptable). The virtio-iommu >> implementation may well return EINVAL from the virtio stack or from the >> host response. > > How about this? > > + * * EINVAL - mainly, device and domain are incompatible, or something went > + * wrong with the domain. It's suggested to avoid kernel prints > + * along with this errno. And it's better to convert any EINVAL > + * returned from kAPIs to ENODEV if it is device-specific, or to > + * some other reasonable errno being listed belowFWIW, I'd say something like: "The device and domain are incompatible. If this is due to some previous configuration of the domain, drivers should not log an error, since it is legitimate for callers to test reuse of an existing domain. Otherwise, it may still represent some fundamental problem." And then at the public interfaces state it from other angle: "The device and domain are incompatible. If the domain has already been used or configured in some way, attaching the same device to a different domain may be expected to succeed. Otherwise, it may still represent some fundamental problem." [ and to save another mail, I'm not sure copying the default comment for ENOSPC is all that helpful either - what is "space" for something that isn't a storage device? I'd guess limited hardware resources in some form, but in the IOMMU context, potential confusion with address space is maybe a little too close for comfort? ]>>>> Since we can't guarantee that APIs like virtio or ida won't ever return >>>> EINVAL, we should set all return values: >>> >>> I dislike this alot, it squashes all return codes to try to optimize >>> an obscure failure path :( > > Hmm...should I revert all the driver changes back to this version?Yeah, I don't think we need to go too mad here. Drivers shouldn't emit their *own* -EINVAL unless appropriate, but if it comes back from some external API then that implies something's gone unexpectedly wrong anyway - maybe it's a transient condition and a subsequent different attach might actually work out OK? We can't really say in general. Besides, if the driver sees an error which implies it's done something wrong itself, it probably shouldn't be trusted to try to reason about it further. The caller can handle any error as long as we set their expectations correctly. Thanks, Robin.