Michael S. Tsirkin
2022-Jun-30 19:16 UTC
[PATCH] virtio: VIRTIO_HARDEN_NOTIFICATION is broken
This option doesn't really work and breaks too many drivers.
Not yet sure what's the right thing to do, for now
let's make sure randconfig isn't broken by this.
Fixes: c346dae4f3fb ("virtio: disable notification hardening by
default")
Cc: "Jason Wang" <jasowang at redhat.com>
Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
---
drivers/virtio/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index e1556d2a355a..afb9051e0125 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -31,11 +31,12 @@ if VIRTIO_MENU
config VIRTIO_HARDEN_NOTIFICATION
bool "Harden virtio notification"
+ depends on BROKEN
help
Enable this to harden the device notifications and suppress
those that happen at a time where notifications are illegal.
- Experimental: Note that several drivers still have bugs that
+ Experimental: Note that several drivers still have issues that
may cause crashes or hangs when correct handling of
notifications is enforced; depending on the subset of
drivers and devices you use, this may or may not work.
--
MST
On Fri, Jul 1, 2022 at 3:16 AM Michael S. Tsirkin <mst at redhat.com> wrote:> > This option doesn't really work and breaks too many drivers. > Not yet sure what's the right thing to do, for now > let's make sure randconfig isn't broken by this. > > Fixes: c346dae4f3fb ("virtio: disable notification hardening by default") > Cc: "Jason Wang" <jasowang at redhat.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com>Acked-by: Jason Wang <jasowang at redhat.com>> --- > drivers/virtio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index e1556d2a355a..afb9051e0125 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -31,11 +31,12 @@ if VIRTIO_MENU > > config VIRTIO_HARDEN_NOTIFICATION > bool "Harden virtio notification" > + depends on BROKEN > help > Enable this to harden the device notifications and suppress > those that happen at a time where notifications are illegal. > > - Experimental: Note that several drivers still have bugs that > + Experimental: Note that several drivers still have issues that > may cause crashes or hangs when correct handling of > notifications is enforced; depending on the subset of > drivers and devices you use, this may or may not work. > -- > MST >
On Thu, Jun 30 2022, "Michael S. Tsirkin" <mst at redhat.com> wrote:> This option doesn't really work and breaks too many drivers. > Not yet sure what's the right thing to do, for now > let's make sure randconfig isn't broken by this. > > Fixes: c346dae4f3fb ("virtio: disable notification hardening by default") > Cc: "Jason Wang" <jasowang at redhat.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)Reviewed-by: Cornelia Huck <cohuck at redhat.com>