On Thu, Jun 23, 2022 at 3:21 AM Eugenio Perez Martin <eperezma at redhat.com> wrote:> > On Wed, Jun 22, 2022 at 5:39 PM Stefano Garzarella <sgarzare at redhat.com> wrote: > > > > Hi, > > while developing/testing the vdpa-blk support in libblkio [1], I > > realized that we added several regressions with the "[PATCH v2 00/19] > > Control VQ support in vDPA" series (patches/clarifications already > > sent). > > > > To minimize these problems in the future, I was thinking of adding tests > > for vhost_vdpa in tools/virtio using vDPA simulators as devices. > > > > What do you think about this? > > I think it's definitely a good idea. Maybe a good starting point is to > copy the virtio_test for the moment? > > Maybe to add a new parameter to tell it it will test a vhost-vdpa > device? Initialization is pretty similar.+1 Thanks> > Thanks! > > > Before starting, please let me know if we already have something. > > > > Thanks, > > Stefano > > > > [1] https://gitlab.com/libblkio/libblkio > > >
On Thu, Jun 23, 2022 at 11:59:56AM +0800, Jason Wang wrote:>On Thu, Jun 23, 2022 at 3:21 AM Eugenio Perez Martin ><eperezma at redhat.com> wrote: >> >> On Wed, Jun 22, 2022 at 5:39 PM Stefano Garzarella <sgarzare at redhat.com> wrote: >> > >> > Hi, >> > while developing/testing the vdpa-blk support in libblkio [1], I >> > realized that we added several regressions with the "[PATCH v2 00/19] >> > Control VQ support in vDPA" series (patches/clarifications already >> > sent). >> > >> > To minimize these problems in the future, I was thinking of adding tests >> > for vhost_vdpa in tools/virtio using vDPA simulators as devices. >> > >> > What do you think about this? >> >> I think it's definitely a good idea. Maybe a good starting point is to >> copy the virtio_test for the moment? >> >> Maybe to add a new parameter to tell it it will test a vhost-vdpa >> device? Initialization is pretty similar. > >+1 >Good idea, I will use it as a starting point. Thanks, Stefano