Jason Wang
2021-Aug-03 08:02 UTC
[PATCH v10 07/17] virtio: Don't set FAILED status bit on device index allocation failure
? 2021/7/29 ??3:34, Xie Yongji ??:> We don't need to set FAILED status bit on device index allocation > failure since the device initialization hasn't been started yet. > This doesn't affect runtime, found in code review. > > Signed-off-by: Xie Yongji <xieyongji at bytedance.com>Does it really harm? Thanks> --- > drivers/virtio/virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index 4b15c00c0a0a..a15beb6b593b 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -338,7 +338,7 @@ int register_virtio_device(struct virtio_device *dev) > /* Assign a unique device index and hence name. */ > err = ida_simple_get(&virtio_index_ida, 0, 0, GFP_KERNEL); > if (err < 0) > - goto out; > + return err; > > dev->index = err; > dev_set_name(&dev->dev, "virtio%u", dev->index);