Colin King
2021-Mar-03 13:43 UTC
[PATCH] scsi: target: vhost-scsi: remove redundant initialization of variable ret
From: Colin Ian King <colin.king at canonical.com>
The variable ret is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
drivers/vhost/scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index d16c04dcc144..9129ab8187fd 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -2465,7 +2465,7 @@ static const struct target_core_fabric_ops vhost_scsi_ops
= {
static int __init vhost_scsi_init(void)
{
- int ret = -ENOMEM;
+ int ret;
pr_debug("TCM_VHOST fabric module %s on %s/%s"
" on "UTS_RELEASE"\n", VHOST_SCSI_VERSION,
utsname()->sysname,
--
2.30.0
Stefan Hajnoczi
2021-Mar-04 17:15 UTC
[PATCH] scsi: target: vhost-scsi: remove redundant initialization of variable ret
On Wed, Mar 03, 2021 at 01:43:39PM +0000, Colin King wrote:> From: Colin Ian King <colin.king at canonical.com> > > The variable ret is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king at canonical.com> > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)Which kernel version is this patch based on? If it's a fix for a patch that hasn't landed yet, please indicate this. A "Fixes: ..." tag should be added to this patch as well. I looked at linux.git/master commit f69d02e37a85645aa90d18cacfff36dba370f797 and see this: static int __init vhost_scsi_init(void) { int ret = -ENOMEM; pr_debug("TCM_VHOST fabric module %s on %s/%s" " on "UTS_RELEASE"\n", VHOST_SCSI_VERSION, utsname()->sysname, utsname()->machine); /* * Use our own dedicated workqueue for submitting I/O into * target core to avoid contention within system_wq. */ vhost_scsi_workqueue = alloc_workqueue("vhost_scsi", 0, 0); if (!vhost_scsi_workqueue) goto out; We need ret's initialization value here ^ ret = vhost_scsi_register(); if (ret < 0) goto out_destroy_workqueue; ret = target_register_template(&vhost_scsi_ops); if (ret < 0) goto out_vhost_scsi_deregister; return 0; out_vhost_scsi_deregister: vhost_scsi_deregister(); out_destroy_workqueue: destroy_workqueue(vhost_scsi_workqueue); out: return ret; };> > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index d16c04dcc144..9129ab8187fd 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -2465,7 +2465,7 @@ static const struct target_core_fabric_ops vhost_scsi_ops = { > > static int __init vhost_scsi_init(void) > { > - int ret = -ENOMEM; > + int ret; > > pr_debug("TCM_VHOST fabric module %s on %s/%s" > " on "UTS_RELEASE"\n", VHOST_SCSI_VERSION, utsname()->sysname, > -- > 2.30.0 >-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20210304/37cc4a70/attachment-0001.sig>