On 2020/12/29 ??3:28, Eli Cohen wrote:>> @@ -43,6 +43,8 @@ struct vdpa_vq_state {
>> * @index: device index
>> * @features_valid: were features initialized? for legacy guests
>> * @nvqs: the number of virtqueues
>> + * @ngroups: the number of virtqueue groups
>> + * @nas: the number of address spaces
> I am not sure these can be categorised as part of the state of the VQ.
> It's more of a property so maybe we can have a callback to get the
> properties of the VQ?
>
> Moreover, I think they should be handled in the hardware drivers to
> return 1 for both ngroups and nas.
We can, but those are static attributes that is not expected to be
changed by the driver.
Introduce callbacks for those static stuffs does not give us any advantage.
For group id and notification area, since we don't have a abstract of
vdpa_virtqueue. The only choice is to introduce callbacks for them.
Maybe it's time to introduce vdpa_virtqueue.
Thanks