Stefano Garzarella
2020-Dec-18 07:56 UTC
[PATCH -next] vdpa: Mark macaddr_buf with static keyword
On Fri, Dec 18, 2020 at 09:51:35AM +0800, Zou Wei wrote:>Fix the following sparse warning: > >drivers/vdpa/vdpa_sim/vdpa_sim_net.c:36:4: warning: symbol 'macaddr_buf' was not declared. Should it be static? > >Reported-by: Hulk Robot <hulkci at huawei.com> >Signed-off-by: Zou Wei <zou_wei at huawei.com> >--- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> I built with W=1 but I didn't have this warning. Thanks for fixing, Stefano> >diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >index c10b698..f048242 100644 >--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >@@ -33,7 +33,7 @@ static char *macaddr; > module_param(macaddr, charp, 0); > MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); > >-u8 macaddr_buf[ETH_ALEN]; >+static u8 macaddr_buf[ETH_ALEN]; > > static struct vdpasim *vdpasim_net_dev; > >-- >2.6.2 >