Willem de Bruijn
2020-Dec-16 14:17 UTC
[PATCH net v2 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails
On Wed, Dec 16, 2020 at 3:26 AM wangyunjian <wangyunjian at huawei.com> wrote:> > From: Yunjian Wang <wangyunjian at huawei.com> > > Currently the vhost_zerocopy_callback() maybe be called to decrease > the refcount when sendmsg fails in tun. The error handling in vhost > handle_tx_zerocopy() will try to decrease the same refcount again. > This is wrong. To fix this issue, we only call vhost_net_ubuf_put() > when vq->heads[nvq->desc].len == VHOST_DMA_IN_PROGRESS. > > Fixes: 0690899b4d45 ("tun: experimental zero copy tx support") > > Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>Acked-by: Willem de Bruijn <willemb at google.com> for next time: it's not customary to have an empty line between Fixes and Signed-off-by