weiping zhang
2017-Dec-21 12:40 UTC
[PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev
rproc_virtio_dev_release will be called iff virtio_device.dev's
reference count drops to 0. Here we just put vdev.dev, and then
rproc->dev's cleanup will be done in rproc_virtio_dev_release.
Signed-off-by: weiping zhang <zhangweiping at didichuxing.com>
---
drivers/remoteproc/remoteproc_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_virtio.c
b/drivers/remoteproc/remoteproc_virtio.c
index 2946348..b0633fd 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -327,7 +327,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
ret = register_virtio_device(vdev);
if (ret) {
- put_device(&rproc->dev);
+ put_device(&vdev->dev);
dev_err(dev, "failed to register vdev: %d\n", ret);
goto out;
}
--
2.9.4
Cornelia Huck
2017-Dec-22 13:40 UTC
[PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev
On Thu, 21 Dec 2017 20:40:58 +0800 weiping zhang <zhangweiping at didichuxing.com> wrote:> rproc_virtio_dev_release will be called iff virtio_device.dev's > reference count drops to 0. Here we just put vdev.dev, and then > rproc->dev's cleanup will be done in rproc_virtio_dev_release. > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> > --- > drivers/remoteproc/remoteproc_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by: Cornelia Huck <cohuck at redhat.com>
Bjorn Andersson
2018-Jan-02 17:34 UTC
[PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev
On Thu 21 Dec 04:40 PST 2017, weiping zhang wrote:> rproc_virtio_dev_release will be called iff virtio_device.dev's > reference count drops to 0. Here we just put vdev.dev, and then > rproc->dev's cleanup will be done in rproc_virtio_dev_release. > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com>Thanks weiping and Cornelia, applied. Regards, Bjorn> --- > drivers/remoteproc/remoteproc_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 2946348..b0633fd 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -327,7 +327,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > > ret = register_virtio_device(vdev); > if (ret) { > - put_device(&rproc->dev); > + put_device(&vdev->dev); > dev_err(dev, "failed to register vdev: %d\n", ret); > goto out; > } > -- > 2.9.4 >