Dan Carpenter
2016-Apr-01 11:02 UTC
[patch] virtio: silence uninitialized variable warnings
Most ->get() functions seem to call BUG_ON() if offset + len is out of range, but rproc_virtio_get() returns early without initializing ret. Presumably it can't actually happen but it leads to a static checker warning. Let's just initialize "ret". Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 6e6cb0c9..597dbef 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -334,7 +334,7 @@ static inline void virtio_cread_bytes(struct virtio_device *vdev, static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset) { - u8 ret; + u8 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return ret; } @@ -348,7 +348,7 @@ static inline void virtio_cwrite8(struct virtio_device *vdev, static inline u16 virtio_cread16(struct virtio_device *vdev, unsigned int offset) { - u16 ret; + u16 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return virtio16_to_cpu(vdev, (__force __virtio16)ret); } @@ -363,7 +363,7 @@ static inline void virtio_cwrite16(struct virtio_device *vdev, static inline u32 virtio_cread32(struct virtio_device *vdev, unsigned int offset) { - u32 ret; + u32 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return virtio32_to_cpu(vdev, (__force __virtio32)ret); } @@ -378,7 +378,7 @@ static inline void virtio_cwrite32(struct virtio_device *vdev, static inline u64 virtio_cread64(struct virtio_device *vdev, unsigned int offset) { - u64 ret; + u64 ret = 0; __virtio_cread_many(vdev, offset, &ret, 1, sizeof(ret)); return virtio64_to_cpu(vdev, (__force __virtio64)ret); }
Seemingly Similar Threads
- [patch] virtio: silence uninitialized variable warnings
- [PATCH v3 24/38] virtio_config: rewrite using _Generic
- [PATCH v3 23/38] virtio_config: cread/write cleanup
- [PATCH 6/6] virtio: core support for config generation
- [PATCH 6/6] virtio: core support for config generation