Stephen Hemminger
2010-Nov-10 06:20 UTC
[PATCH] virtio: fix format of sysfs driver/vendor files
The sysfs files for virtio produce the wrong format and are missing the required newline. The output for virtio bus vendor/device should have the same format as the corresponding entries for PCI devices. Although this technically changes the ABI for sysfs, these files were broken to start with! Signed-off-by: Stephen Hemminger <shemminger at vyatta.com> --- a/drivers/virtio/virtio.c 2010-11-09 21:39:31.713916249 -0800 +++ b/drivers/virtio/virtio.c 2010-11-09 21:40:16.072089461 -0800 @@ -9,19 +9,19 @@ static ssize_t device_show(struct device struct device_attribute *attr, char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); - return sprintf(buf, "%hu", dev->id.device); + return sprintf(buf, "0x%04x\n", dev->id.device); } static ssize_t vendor_show(struct device *_d, struct device_attribute *attr, char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); - return sprintf(buf, "%hu", dev->id.vendor); + return sprintf(buf, "0x%04x\n", dev->id.vendor); } static ssize_t status_show(struct device *_d, struct device_attribute *attr, char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); - return sprintf(buf, "0x%08x", dev->config->get_status(dev)); + return sprintf(buf, "0x%08x\n", dev->config->get_status(dev)); } static ssize_t modalias_show(struct device *_d, struct device_attribute *attr, char *buf)
Rusty Russell
2010-Nov-10 12:51 UTC
[PATCH] virtio: fix format of sysfs driver/vendor files
On Wed, 10 Nov 2010 04:50:29 pm Stephen Hemminger wrote:> The sysfs files for virtio produce the wrong format and are missing > the required newline. The output for virtio bus vendor/device should > have the same format as the corresponding entries for PCI devices. > > Although this technically changes the ABI for sysfs, these files were > broken to start with!Agreed, and I don't think anyone currently uses them. Applied, Rusty.
Reasonably Related Threads
- [PATCH] virtio: fix format of sysfs driver/vendor files
- [PATCH 5/8] virtio: convert bus code to use dev_groups
- [PATCH 5/8] virtio: convert bus code to use dev_groups
- patch "virtio: convert bus code to use dev_groups" added to driver-core tree
- patch "virtio: convert bus code to use dev_groups" added to driver-core tree