Greg Kroah-Hartman
2009-Jul-17 18:09 UTC
[patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock
An embedded and charset-unspecified text was scrubbed... Name: staging-hv-make-gvmbusconnection.channellock-a-real-spinlock.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090717/01b2e23a/attachment.txt
Arnd Bergmann
2009-Jul-20 23:39 UTC
[patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock
On Friday 17 July 2009, Greg Kroah-Hartman wrote:> I don't think we really want to be doing a irqsave for this code, but I > left it alone to preserve the original codepath. It should be reviewed > later.This patch does not preserve the original code path if any of the callers has a different irq state from the others. When flags is shared, releasing the lock actually sets the irq state to whatever another thread was using when failing to acquire the lock while it was held. The patch of course looks good, but the comment is misleading. Arnd <><
Maybe Matching Threads
- [patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock
- [PATCH 1/1] staging: hv: Fix race condition on vmbus channel initialization
- [PATCH 1/1] staging: hv: Fix race condition on vmbus channel initialization
- [PATCH 2/2] staging: hv: Remove camel cases from vmbus channel functions
- [PATCH 2/2] staging: hv: Remove camel cases from vmbus channel functions