I think I botched syslinux-6.04-pre3. There are two fundamental problems with the build: a) The selection of what pieces of the library gets included in the core is done manually whereas it really should be automatic; b) The build doesn't fail if there are unresolved dependencies between the libraries and the core. I will fix these. (b) is IMO fundamental to avoid this error in the future, so I want to fix it correctly. -hpa
On Mon, 2019-02-11 at 12:15 -0800, H. Peter Anvin via Syslinux wrote:> > > I think I botched syslinux-6.04-pre3. There are two fundamental > problems with the build: > > a) The selection of what pieces of the library gets included in the core > is done manually whereas it really should be automatic; > > b) The build doesn't fail if there are unresolved dependencies between > the libraries and the core. > > I will fix these. (b) is IMO fundamental to avoid this error in the > future, so I want to fix it correctly. > > -hpaI think using -z muldefs when linking against gnu-efi(vs. excluding memcpy/memset) would be beneficial. That way building syslinux against older/future gnu-efi will not break and you get your optimized memset/memcpy impl. Gnu-efi just has the simplest impl. of these functions. Jocke
On February 11, 2019 12:29:41 PM PST, Joakim Tjernlund <Joakim.Tjernlund at infinera.com> wrote:>On Mon, 2019-02-11 at 12:15 -0800, H. Peter Anvin via Syslinux wrote: >> >> >> I think I botched syslinux-6.04-pre3. There are two fundamental >> problems with the build: >> >> a) The selection of what pieces of the library gets included in the >core >> is done manually whereas it really should be automatic; >> >> b) The build doesn't fail if there are unresolved dependencies >between >> the libraries and the core. >> >> I will fix these. (b) is IMO fundamental to avoid this error in the >> future, so I want to fix it correctly. >> >> -hpa > >I think using -z muldefs when linking against gnu-efi(vs. excluding >memcpy/memset) would be beneficial. >That way building syslinux against older/future gnu-efi will not break >and you get your >optimized memset/memcpy impl. Gnu-efi just has the simplest impl. of >these functions. > > JockeNo. It really is the wrong thing to do, and could mask very serious bugs. It also doesn't solve any of these problems -- Sent from my Android device with K-9 Mail. Please excuse my brevity.