On Wed, 2018-12-12 at 17:05 -0600, Carl Karsten wrote:> On Wed, Dec 12, 2018 at 4:54 PM Joakim Tjernlund > <Joakim.Tjernlund at infinera.com> wrote: > > On Wed, 2018-12-12 at 16:00 -0600, Carl Karsten via Syslinux wrote: > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > > > > > On Tue, Dec 11, 2018 at 9:19 PM Ady Ady via Syslinux <syslinux at zytor.com> wrote: > > > > > > You should be able to see the effects of the DISPLAY directive when > > > > > > testing the floppy image I sent you, because it starts with the boot > > > > > > prompt, not with a menu. > > > > > > > > > > I see the effects, both good and bad. I'm having trouble knowing how > > > > > bad the bad is. > > > > > > > > How about comparing it with the current behaviour in BIOS mode? > > > > > > Everything in current BIOS mode works perfectly as far as I can tell. > > > We know things are different with efi, but that alone isn't a blocker. > > > > Have you tried to updating to a newer gnu-efi ? The one included in syslinux is very old. > > I am using the binaries from > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsources.debian.org%2Fsrc%2Fsyslinux%2F3%3A6.04%257Egit20171011.af7e95c3%2Bdfsg1-6%2Fdebian%2Fchangelog%2F&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7C1d50b660417a4c6e2c3f08d66086688e%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C636802527742019220&sdata=UYyZaxiiKgLpp%2BrdXmZ3UMVRkvTCagf2SZk%2FVtZnGdM%3D&reserved=0 >I cannot tell but I guess you are using newer gnu-efi. You should check how your repo does this: https://github.com/joakim-tjernlund/syslinux/commit/22d32c15ea96c01c8c05b8c1551095716d42f3a4
Hi Joakim, On Wed, 12 Dec 2018 23:25:24 +0000 Joakim Tjernlund via Syslinux <syslinux at zytor.com> wrote:> I cannot tell but I guess you are using newer gnu-efi. You should > check how your repo does this: > https://github.com/joakim-tjernlund/syslinux/commit/22d32c15ea96c01c8c05b8c1551095716d42f3a4This is the corresponding patch used in Debian: https://salsa.debian.org/images-team/syslinux/blob/debian/master/debian/patches/0005-gnu-efi-version-compatibility.patch The package automatically builds against the gnu-efi version that's available in Debian at build time. At the moment that's 3.0.9 and the version Carl uses is linked against that. Regards Lukas
On Mon, 2018-12-17 at 23:52 +0100, Lukas Schwaighofer wrote:> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > Hi Joakim, > > On Wed, 12 Dec 2018 23:25:24 +0000 > Joakim Tjernlund via Syslinux <syslinux at zytor.com> wrote: > > > I cannot tell but I guess you are using newer gnu-efi. You should > > check how your repo does this: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjoakim-tjernlund%2Fsyslinux%2Fcommit%2F22d32c15ea96c01c8c05b8c1551095716d42f3a4&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7C9725124082b543278fc208d664725495%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C1%7C636806839586869257&sdata=WVzVxf1mhnSeHkm0BEARy7e3W8kmPpB6a%2Bf7eSCG8rg%3D&reserved=0 > > This is the corresponding patch used in Debian: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsalsa.debian.org%2Fimages-team%2Fsyslinux%2Fblob%2Fdebian%2Fmaster%2Fdebian%2Fpatches%2F0005-gnu-efi-version-compatibility.patch&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7C9725124082b543278fc208d664725495%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C1%7C636806839586869257&sdata=XaFXPhErsWEfypy9vmpoEGI2chUq3GFGIW4z2ql0ywQ%3D&reserved=0 > > The package automatically builds against the gnu-efi version that's > available in Debian at build time. At the moment that's 3.0.9 and the > version Carl uses is linked against that.I suspect this part is wrong: -static jmp_buf load_error_buf; +static jmp_buf *load_error_buf; That will just define a ptr and using that directly in longjmp/setjmp is odd. Modifying longjmp/setjmp to. -longjmp(load_error_buf,1); +longjmp(&load_error_buf,1); makes much more sense to me. Jocke