> Thank you all. > > It looks like -mno-red-zone flag is already in master branch since > commit 7d70885d, but it seems it is applied to all EFI builds.Finally we are on the same page.> > IIUC, the problem only affects efi64 builds.Have you actually tested efi32 (ia32) builds?> > So here's the modification of my patch to only apply -mno-red-zone > flag to efi64 target. The patch is against master. I verified that it > builds correctly in master. Please feel free to accept or reject this > solution. > > Best Regards, > - ChrisI still have some problem understanding this situation (FWIW). If the -mno-red-zone flag was already applied for all EFI builds (in the current git master head and in 6.04-pre1), then what exactly makes the current 6.04-pre1 *pre-built* binaries fail for you? As Jur van der Burg reported, 6.04-pre1 works just as well as your previously-proposed patch; so, what exactly are we changing now that is not already achieved in the current code? I am failing to grasp what exactly was making it fail for you. I apologize if these questions are trivial to others; to me they are not. Anyway, I appreciate contributions and I hope to see more active and effective Syslinux development. Regards, Ady.
> If the -mno-red-zone flag was already applied for all EFI builds (in > the current git master head and in 6.04-pre1), then what exactly makes > the current 6.04-pre1 *pre-built* binaries fail for you?You are right, Ady. I have no way of knowing whether 6.04-pre1 works or not. I've got this bug from a customer who has systems where syslinux fails. Unfortunately I don't have access to these systems. I sent them a 6.04-pre1 build, but I got mixed answers, I don't know for sure if they tried it or not. They did try my later build based on 6.03 with my original patch. I also have no way of confirming what is the impact of the efi32 build. It's an omission on my end that I did not check what was in 6.04-pre1, I assumed it did not work without proper investigation. Let me double check what the status of 6.04-pre1 is. Maybe this patch is not necessary at all! Sorry for the churn. Best Regards, - Chris
> Let me double check what the status of 6.04-pre1 is. Maybe this patch > is not necessary at all!Just a reminder: _ 6.04-pre1 can be downloaded from kernel.org, and it includes pre-built binaries, so no "make" anything is needed (and to some degree, not always recommended). _ In many cases, testing with pre-built official binaries is desired, so others can attempt to reproduce the results, minimizing the impact of potential differences in building environments. _ All Syslinux-related files should be originated from the same build / version. Mixing, for example, syslinux.efi from one build with ldlinux.e64 (or any c32 file) from another build is very much discouraged, unless explicitly requested for some very specific test. _ It is very easy to mistakenly mix c32 files from one platform (say, efi32) with the equivalent c32 from another platform (say, from efi64), because they only differ in their respective path directories (they have the same name, except for ldlinux.*). Using the "wrong" c32 file (e.g. pertaining to a different platform than the one is being attempted to boot) will result in unpredictable behavior. _ 6.04-pre1 is not "perfect", but it is a relevant test in the current context. Regards, Ady.