Celelibi
2016-Jan-22 02:33 UTC
[syslinux] [PATCH 2/2] core: Fix stack overflow when reloading config
2016-01-22 3:23 UTC+01:00, Celelibi <celelibi at gmail.com>:> 2016-01-21 21:51 UTC+01:00, H. Peter Anvin <hpa at zytor.com>: >> On 10/12/15 21:04, celelibi--- via Syslinux wrote: >>> From: Sylvain Gault <sylvain.gault at gmail.com> >>> >>> The behavior when running a "CONFIG" command line is to reload >>> ldlinux.c32 with the new file as argument. This call never return. >>> >>> In order to avoid stacking up the calls to start_ldlinux, this patch >>> introduce a setjmp/longjmp to return to the first call to start_ldlinux, >>> thus freeing all the stack space. >>> >>> Signed-off-by: Sylvain Gault <sylvain.gault at gmail.com> >> >> We don't re*load* ldlinux.c32, I hope? I assume we just re-execute it? >> >> -hpa > > Well, ldlinux.c32 is unloaded explicitely in the function > start_ldlinux. It is then actually reloaded by a call to spawn_load. > Network capture just confirmed it. > > Do you wish something else to happen? > > It is, indeed, a waste of time reloading the very same file again and > again. But I hope it was made this way for simplicity. > > > Celelibi >BTW, this code is due to Matt Flemming with commit 3a316db1 (later modified). The commit log say this: ldlinux: Loading a config file should cause re-initialisation There are a number of initialisation steps that need to be performed *every* time a config file is loaded. Reload ldlinux.c32 so that we can re-initialise the environment whenever a new config file is loaded. This involves unloading all the modules that have been loaded since ldlinux.c32. Luckily the list of loaded modules is sorted by load order, which means it's trivial to "pop" them from the front of the list. ---------------------- Celelibi
H. Peter Anvin
2016-Jan-22 02:37 UTC
[syslinux] [PATCH 2/2] core: Fix stack overflow when reloading config
On 01/21/16 18:33, Celelibi wrote:> > BTW, this code is due to Matt Flemming with commit 3a316db1 (later > modified). The commit log say this: > ldlinux: Loading a config file should cause re-initialisation > > There are a number of initialisation steps that need to be performed > *every* time a config file is loaded. Reload ldlinux.c32 so that we > can re-initialise the environment whenever a new config file is > loaded. This involves unloading all the modules that have been loaded > since ldlinux.c32. Luckily the list of loaded modules is sorted by > load order, which means it's trivial to "pop" them from the front of > the list. >Yes, it is the easy way to initialize. Part of me wonders if we should keep a copy of the data section and just wipe it out. -hpa
Celelibi
2016-Jan-22 11:59 UTC
[syslinux] [PATCH 2/2] core: Fix stack overflow when reloading config
2016-01-22 3:37 UTC+01:00, H. Peter Anvin <hpa at zytor.com>:> On 01/21/16 18:33, Celelibi wrote: >> >> BTW, this code is due to Matt Flemming with commit 3a316db1 (later >> modified). The commit log say this: >> ldlinux: Loading a config file should cause re-initialisation >> >> There are a number of initialisation steps that need to be performed >> *every* time a config file is loaded. Reload ldlinux.c32 so that we >> can re-initialise the environment whenever a new config file is >> loaded. This involves unloading all the modules that have been loaded >> since ldlinux.c32. Luckily the list of loaded modules is sorted by >> load order, which means it's trivial to "pop" them from the front of >> the list. >> > > Yes, it is the easy way to initialize. Part of me wonders if we should > keep a copy of the data section and just wipe it out. > > -hpaI see 3 ways of handling this. 1) Have some specific code in ldlinux.c32 that handles reinitialization. 2) Have some specific cache for the COM32 modules and load them only once for the lifetime of the whole boot loader. 3) Put a file system cache that would also benefit to other files. I would tend to prefer the third way, but I don't know how much work it would be or if it would integrate well in the current design. Celelibi
Seemingly Similar Threads
- [PATCH 2/2] core: Fix stack overflow when reloading config
- [PATCH 2/2] core: Fix stack overflow when reloading config
- [PATCH 2/2] core: Fix stack overflow when reloading config
- [PATCH 2/2] core: Fix stack overflow when reloading config
- [PATCH 2/2] core: Fix stack overflow when reloading config