Op 2014-06-22 om 22:31 schreef Geert Stappers:> Op 2014-06-22 om 21:02 schreef Thomas Schmitt: > > > > following will be 6 patch proposals for isohybrid.c > > > > 1: Encode GPT partition names as UTF-16LE > > 2: Correct blocking factor in APM partition block counts > > 3: Correct end block address of first GPT partition > > 4: Write GPT backup to the very end of the image > > 5: Change all fseek(3) to fseeko(3) > > 6: Introduce option --mbr and make isohybrid.c compilable standalone > > > > If the form needs adjustments, i whould be able to reproduce the > > patches. > > Those patches regenerated from git are send to Thomas and the ML. > We will see is they go a cross various e-mail (spam) filters.We will see if they go a cross various e-mail (spam) filters. They did all six. There was a seventh patch. It uses also reformatting. Don't wait for me do it. Groeten Geert Stappers -- Leven en laten leven
Hi,> There was a seventh patch.Yes. A late one because of more testing. Not only my --mbr, but also --mac and --uefi promised short options in their help text, but did not prepare the options string for getopt(3) to recognize these options.> It uses also reformatting. > Don't wait for me do it.If you explain to me what is necessary (and maybe also why), then i could try to do it myself. ----------------------------------------------------------------- About the pondered adjustment of ISO image size to the isohybrid padding: isohybrid pads up the image file to a full cylinder size, but leaves the ISO filesystem size unchanged. This puts the backup GPT in danger not to be copied onto medium, if the copy program uses the ISO filesystem size. It also does not match the behavior of mkisofs which includes its own padding in the filesystem size. When preparing for writing the backup GPT, isohybrid.c checks whether there is enough room for 33*512 bytes between filesystem end and image file end. If not, then it applies padding even if the cylinder alignment is already fulfilled. Adjusting the image size to protect the backup GPT will therefore cause new padding of one cylinder size. One could check whether the last 33*512 bytes of the ISO filesystem are occupied by a backup GPT. There are id texts and CRC-32 sums. So it would be quite unambigous. Nevertheless, this will stay guesswork and potentially risky for the content of the ISO filesystem. So i gave up the idea to unconditionally adjust filesystem size to image file size. It might neverthelss be a valuable option. E.g. --adjust_fs_size. Have a nice day :) Thomas
Op 2014-06-23 om 08:50 schreef Thomas Schmitt:> Hi, > > > There was a seventh patch. > > > It uses also reformatting. > > Don't wait for me do it. > > If you explain to me what is necessary (and maybe also why), > then i could try to do it myself. >The patch is generated with `diff`. That is good. Make it possible that the patch can be applied with `patch` without manual entering a file name. So avoid/prevent answering a dialog like: |--- isohybrid.c.006_opt_mbr_standalone 2014-06-22 20:10:49.000000000 +0200 |+++ isohybrid.c.007_short_opts_umb 2014-06-23 19:52:59.000000000 +0200 -------------------------- File to patch: Groeten Geert Stappers -- Leven en laten leven
Possibly Parallel Threads
- Announcing a patch series for isohybrid.c
- Announcing a patch series for isohybrid.c
- isohybrid and ISO images whose size is not a multiple of 2048 bytes vs. VirtualBox
- isohybrid and ISO images whose size is not a multiple of 2048 bytes vs. VirtualBox
- isohybrid and ISO images whose size is not a multiple of 2048 bytes vs. VirtualBox