H. Peter Anvin
2013-Jul-12 16:54 UTC
[syslinux] [syslinux:firmware] efi, udp: implement receive timeout
On 07/12/2013 05:57 AM, syslinux-bot for Matt Fleming wrote:> Commit-ID: 7ab8f23aa2140951608544ed557f7529cf32d98d > Gitweb: http://www.syslinux.org/commit/7ab8f23aa2140951608544ed557f7529cf32d98d > Author: Matt Fleming <matt.fleming at intel.com> > AuthorDate: Fri, 12 Jul 2013 13:47:22 +0100 > Committer: Matt Fleming <matt.fleming at intel.com> > CommitDate: Fri, 12 Jul 2013 13:53:07 +0100 > > efi, udp: implement receive timeout > > We currently wait indefinitely in core_udp_recv() when reading packets. > Implement a timeout, which is what all the other network stacks do. By > timing out we are now able to handle packet loss on the network, e.g. > we'll now re-send TFTP requests instead of waiting for ACK packets that > will never come. >Hmmm. We already have a timeout loop in tftp_get_packet() as well as in the legacy version of dns_resolv(). I would like to suggest we augment the generic UDP receive function call with a timeout, rather than implementing a timeout upon a timeout. What do you think? -hpa
Matt Fleming
2013-Jul-12 18:52 UTC
[syslinux] [syslinux:firmware] efi, udp: implement receive timeout
On Fri, 12 Jul, at 09:54:43AM, H. Peter Anvin wrote:> Hmmm. > > We already have a timeout loop in tftp_get_packet() as well as in the > legacy version of dns_resolv(). > > I would like to suggest we augment the generic UDP receive function call > with a timeout, rather than implementing a timeout upon a timeout. > > What do you think?Yeah, that would seem to make sense. I'll take a look at that. -- Matt Fleming, Intel Open Source Technology Center
Reasonably Related Threads
- [PATCH 1/4] efi/udp: core_udp_connect should use SubnetMask not StationAddress for netmask
- syslinux.efi pxeboot across multiple subnets
- syslinux.efi pxeboot across multiple subnets
- syslinux.efi pxeboot across multiple subnets
- syslinux.efi pxeboot across multiple subnets