Syslinux - Jan 2013 - Fwd: Minor syslinux menu system bug report

-------- Original Message --------
From: Alexander Perlis <aperlis at math.lsu.edu>
Sent: Mon Jan 28 18:21:18 PST 2013
To: hpa at zytor.com
Subject: Minor syslinux menu system bug report

Sorry for the intrusion, I know authors dislike receiving direct e-mail, 
but I couldn't see bug report submission info at the syslinux website.

This bug report is for syslinux 4.05 and affects both menu.c32 and 
vesamenu.c32:

   If the very last item in a (sub)menu is disabled, you can nonetheless 
select it by pressing the arrow keys.

This situation might arise for example if one were to include disabled 
messages at the bottom of a menu that are supposed to apply to the 
entire menu and might be preferred in the menu rather than in 
item-specific help text, e.g., "WARNING: These DBAN images will erase 
your data!"

Thanks you.
Alexander Perlis

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.

On Mon, 2013-01-28 at 19:32 -0800, H. Peter Anvin wrote:
> 
> 
> -------- Original Message --------
> From: Alexander Perlis <aperlis at math.lsu.edu>
> Sent: Mon Jan 28 18:21:18 PST 2013
> To: hpa at zytor.com
> Subject: Minor syslinux menu system bug report
> 
> Sorry for the intrusion, I know authors dislike receiving direct e-mail, 
> but I couldn't see bug report submission info at the syslinux website.
> 
> This bug report is for syslinux 4.05 and affects both menu.c32 and 
> vesamenu.c32:
> 
>    If the very last item in a (sub)menu is disabled, you can nonetheless 
> select it by pressing the arrow keys.
> 
> This situation might arise for example if one were to include disabled 
> messages at the bottom of a menu that are supposed to apply to the 
> entire menu and might be preferred in the menu rather than in 
> item-specific help text, e.g., "WARNING: These DBAN images will erase 
> your data!"
This bug was fixed in 4.06 with the following patches,

commit c823574f53c1729790a5d38d02204118389cddf6
Author: Matt Fleming <matt.fleming at intel.com>
Date:   Tue Oct 9 13:33:51 2012 +0100

    menu: Don't highlight disabled entries
    
    There's an off-by-one bug in the menu input handling code which makes
    it possible to highlight/select the last entry in a menu even if that
    entry is disabled.
    
    It should be noted that you can't actually *do* anything with the
    disabled entry, i.e. edit or execute it. Still, allowing it to be
    highlighted does look a little strange.
    
    Reported-by: Matt Sephton <matt.sephton at gmail.com>
    Signed-off-by: Matt Fleming <matt.fleming at intel.com>


commit ac3f053411c096dea192e9572c7cb3abc32d8b6e
Author: Matt Fleming <matt.fleming at intel.com>
Date:   Fri Oct 12 12:59:32 2012 +0100

    menu: Disallow navigation to a disabled entry via *any* key
    
    Generalise the fix from commit c823574f53c1 ("menu: Don't highlight
    disabled entries") as it only handled the case where we navigated to a
    disabled last entry by pressing Ctrl + N or the DOWN arrow
    key. Obviously, we can navigate with other keys such as END, PGDN, etc
    so we need to handle all cases.
    
    Reported-by: Ady <ady-sf at hotmail.com>
    Signed-off-by: Matt Fleming <matt.fleming at intel.com>

-- 
Matt Fleming, Intel Open Source Technology Center