---
com32/lib/Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/com32/lib/Makefile b/com32/lib/Makefile
index 93643ce..6923605 100644
--- a/com32/lib/Makefile
+++ b/com32/lib/Makefile
@@ -105,6 +105,8 @@ LIBOBJS = \
syslinux/run_default.o syslinux/run_command.o \
syslinux/cleanup.o syslinux/localboot.o syslinux/runimage.o \
\
+ syslinux/callback.o \
+ \
syslinux/loadfile.o syslinux/floadfile.o syslinux/zloadfile.o \
\
syslinux/load_linux.o syslinux/initramfs.o \
--
1.6.0.2
-----Original Message-----
From: H. Peter Anvin [mailto:hpa at zytor.com]
Sent: Monday, June 07, 2010 5:00 PM
To: For discussion of Syslinux and tftp-hpa
Cc: Ayvaz, James
Subject: Re: [syslinux] [Syslinux] Patch sensible callback framework
On 06/01/2010 05:21 AM, Ayvaz, James wrote:> Following up on this. Were there any more changes that I need to make to
get this patch accepted? Thanks.
> +
> +static inline struct callback_record* register_callback(struct
callback_record *head, callback_t callback, void *rarg) {
Brackets go on the line after the function declaration, please.
The one thing I''d ask is that you make this patch against the
"pathbased" branch on the git tree, or equivalently against the
4.00-pre47 release. Other than that, it''s starting to look really
good.
However, the INIT_CALLBACK() macro is confused. The right way to use a
macro like that is to set it up as follows:
#define DECLARE_CALLBACK(name) \
struct callback_record name = { \
.function = NULL, \
.next = &name, \
.prev = &name, \
}
Then use it at the point of declaration:
DECLARE_CALLBACK(my_callback);
This allows the callback to be initialized statically.
-hpa
_______________________________________________
Syslinux mailing list
Submissions to Syslinux at zytor.com
Unsubscribe or set options at:
http://www.zytor.com/mailman/listinfo/syslinux
Please do not send private replies to mailing list traffic.