Syslinux - Aug 2009 - fsc branch: merged ldlinux.asm and extlinux; failing test

Hi,

I merged ldlinux.asm and extlinux.asm on the fsc branch, observing that
there were very little difference between them left.  So far, so good.

I found, however, a test which fails on the fsc branch (with or without
the merge.)  I have tracked it down to vfat_mangle_name() overwriting a
bunch of random .bss16 memory, eventually including the CallbackSP variable.

http://www.zytor.com/~hpa/syslinux/fattest.tar.bz2

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

On 08/09/2009 10:27 PM, H. Peter Anvin wrote:
> Hi,
> 
> I merged ldlinux.asm and extlinux.asm on the fsc branch, observing that
> there were very little difference between them left.  So far, so good.
> 
> I found, however, a test which fails on the fsc branch (with or without
> the merge.)  I have tracked it down to vfat_mangle_name() overwriting a
> bunch of random .bss16 memory, eventually including the CallbackSP
variable.
> 
> http://www.zytor.com/~hpa/syslinux/fattest.tar.bz2
> 
By the way, the whole notion of mangled name is a historical piece of
ugliness that it would be much nicer if we could get rid of completely.
 If we absolutely must have it, it should be internal to fs->searchdir
(which is really the open function.)

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.