Luciano Miguel Ferreira Rocha
2009-May-12 14:38 UTC
[syslinux] bug in com32/modules/chain.c
Hello, The main function in com32/modules/chain.c does a lot of argument parsing, finding the drivename, partition, seg, etc., for two statements nullifying most of the work: drivename = argv[1]; partition = argv[2]; /* Possibly null */ Seeing as the function initializes the variables correctly at the beginning: drivename = "boot"; partition = NULL; shouldn't these statements be removed? This in syslinux-3.81-pre2. Regards, Luciano Rocha -- lfr 0/0
Luciano Miguel Ferreira Rocha wrote:> Hello, > > The main function in com32/modules/chain.c does a lot of argument > parsing, finding the drivename, partition, seg, etc., for two statements > nullifying most of the work: > > drivename = argv[1]; > partition = argv[2]; /* Possibly null */ > > Seeing as the function initializes the variables correctly at the > beginning: > > drivename = "boot"; > partition = NULL; > > shouldn't these statements be removed? > > This in syslinux-3.81-pre2. >Probably. Will look into it. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.