On Wed, Sep 13, 2023 at 02:51:07PM +0300, Michael Tokarev via samba wrote:>I were setting up msdfs redirections and was curious whenever I can >mix-n-match regular files/directories and msdfs reparse points. >A quick test revealed that both works, more, reparse points are >handled by samba not only in the top-level share directory but also >in subdirectories. Which is quite nice and handy. > >So I updated the wiki page adding this information. > >But it turned out this does not come without a surprise. For example, >right now I see warnings in the log file, like this: > >[2023/09/13 14:42:29.176777, 0] ../../source3/smbd/msdfs.c:170(parse_dfs_path) > parse_dfs_path: can't parse hostname from path FOO >[2023/09/13 14:42:29.176810, 0] ../../source3/smbd/msdfs.c:180(parse_dfs_path) > parse_dfs_path: trying to convert FOO to a local path > >(where FOO being one of top-level directories in the share in question, >where msdfs root is enabled.) This happens not on every access but >sometimes, I don't yet see when exactly. > >So I decided to ask more explicitly. Is it okay to mix-n-match DFS reparse >points and regular files/directories in a share where msdfs root is enabled?What version of Samba ? This code changed for 4.19.x I think.
13.09.2023 19:08, Jeremy Allison wrote:> On Wed, Sep 13, 2023 at 02:51:07PM +0300, Michael Tokarev via samba wrote:..>> [2023/09/13 14:42:29.176777,? 0] ../../source3/smbd/msdfs.c:170(parse_dfs_path) >> ?parse_dfs_path: can't parse hostname from path FOO >> [2023/09/13 14:42:29.176810,? 0] ../../source3/smbd/msdfs.c:180(parse_dfs_path) >> ?parse_dfs_path: trying to convert FOO to a local path>> So I decided to ask more explicitly.? Is it okay to mix-n-match DFS reparse >> points and regular files/directories in a share where msdfs root is enabled? > > What version of Samba ? This code changed for 4.19.x I think.This particular one is 4.17. I had no idea there were changes in this area, but could have guessed since 4.19 had some reparse point changes. And sure thing, welcome commit c3f48b0581e5a948d1f31c8a65e8294aa6c92591 Author: Jeremy Allison <jra at samba.org> Date: Thu Mar 30 13:01:08 2023 -0700 s3: smbd: Remove now unused dfs_filename_convert(). :) - which went to 4.19. Okay, I'll dig around the changes in that area. But the original question becomes even wider :) From the code changes I'm guessing it is okay to intermix regular dirs/files and DFS reparse points. But it looks like some other reparse points are now supported too.. am I right? The wiki page about DFS needs another update or two :) Thank you! /mjt