rsync - Jul 2008 - DO NOT REPLY [Bug 5607] New: 3.0.2 client won't cooperate with 2.6.9 server

https://bugzilla.samba.org/show_bug.cgi?id=5607

           Summary: 3.0.2 client won't cooperate with 2.6.9 server
           Product: rsync
           Version: 3.0.2
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: major
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: andreas.bolsch@alumni.tu-berlin.de
         QAContact: rsync-qa@samba.org


Server: rsync  version 2.6.9  protocol version 29
Client: rsync  version 3.0.2  protocol version 30

Command line:
============rsync -aiHOvvvvvvvv --no-implied-dirs -e ssh --filter '+
files/**/.htaccess'
--filter '+ */' --filter '- files/**' --delete-after
--max-delete 8
/home/abc/def/www/_ghi/ abc12345@homepages.xyz.de:/home/abc12345/public_html

Before update of client (mirror source) from 2.6.9 to 3.0.2:
===========================================================cmd[0]=ssh cmd[1]=-l
cmd[2]=abc12345 cmd[3]=homepages.xyz.de cmd[4]=rsync
cmd[5]=--server cmd[6]=-vvvvvlOHogDtpr cmd[7]=--log-format=%i
cmd[8]=--max-delete=8 cmd[9]=--delete cmd[10]=--delete-after cmd[11]=.
cmd[12]=/home/abc12345/public_html 
opening connection using ssh -l abc12345 homepages.xyz.de rsync --server
-vvvvvlOHogDtpr "--log-format=%i" --max-delete=8 --delete
--delete-after .
/home/abc12345/public_html

(Client) Protocol versions: remote=29, negotiated=29

After update of client:
======================cmd[0]=ssh cmd[1]=-l cmd[2]=abc12345
cmd[3]=homepages.xyz.de cmd[4]=rsync
cmd[5]=--server cmd[6]=-vvvvvvvvlOHogDtpre.i cmd[7]=--log-format=%i
cmd[8]=--max-delete=8 cmd[9]=--delete-after cmd[10]=.
cmd[11]=/home/hg14363/public_html 
opening connection using: ssh -l abc12345 homepages.xyz.de rsync --server
-vvvvvvvvlOHogDtpre.i "--log-format=%i" --max-delete=8 --delete-after
.
/home/abc12345/public_html 
note: iconv_open("ISO-8859-15", "ISO-8859-15") succeeded.

insecure -e option not allowed.
This account is restricted by rssh.
Allowed commands: scp sftp rsync

If you believe this is in error, please contact your system administrator.

rsync: connection unexpectedly closed (0 bytes received so far) [sender]

==============================================================================Apparently
the 2.6.9 server gets confused by the "e." option in cmd[6]. After
commenting out addition of "e." in options.c:server_options()
everythings works
as before.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607


matt@mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




------- Comment #1 from matt@mattmccutchen.net  2008-07-10 16:46 CST -------
Note this message:
> insecure -e option not allowed.
> This account is restricted by rssh.
I.e., the error is coming not from the rsync server but from a restricted-rsync
wrapper that rejects the -e option.  That option is perfectly safe for rsync
servers, so the wrapper should be updated to allow it.  See this thread:

http://lists.samba.org/archive/rsync/2008-March/020441.html


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607





------- Comment #2 from wayned@samba.org  2008-07-10 17:01 CST -------
As the thread that Matt pointed out mentions, -e is completely safe as long as
the command has the --server option.  The rrsync script requires it to be the
first option on the command-line, which is an easy check and works for normal
cases (and can even work with someone who is passing --rsync-path="rsync
--options" as long as the user specifies their own --server option as the
first
option).

One thing that rsync 3 could be improved to do is to omit that "e..."
sequence
if --protocol=29 is specified.  That would at least make it easy for a user to
communicate with an overly restrictive server that won't update their
software.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607





------- Comment #3 from wayned@samba.org  2008-07-10 17:13 CST -------
Created an attachment (id=3403)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3403&action=view)
Make --protocol=29 option disable sending of -e... to the server

With this patch, you can specify --protocol=29 to and rsync 3 client and
won't
send the -e... flags.  Thoughts?


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607





------- Comment #4 from andreas.bolsch@alumni.tu-berlin.de  2008-07-11 00:50 CST
-------
(In reply to comment #3)
> Created an attachment (id=3403)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3403&action=view)
[edit]
> Make --protocol=29 option disable sending of -e... to the server
> 
> With this patch, you can specify --protocol=29 to and rsync 3 client and
won't
> send the -e... flags.  Thoughts?
> 
This seems to be a feasible option when the user is not allowed to update the
server / wrapper. 


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |enhancement
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |
            Summary|3.0.2 client won't cooperate|Add a way to elide the
                   |with 2.6.9 server           |client's use of -e to the
                   |                            |server




------- Comment #5 from wayned@samba.org  2008-07-11 11:37 CST -------
Since the -e flags to the server are only used in protocol 30, attaching this
side effect to the --protocol=29 flag is a safe way to go.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5607


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #6 from wayned@samba.org  2008-07-11 11:47 CST -------
This change is now in the git repository.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.