rsync - May 2008 - DO NOT REPLY [Bug 5505] New: rsync 3.x reporting excluded files as error

https://bugzilla.samba.org/show_bug.cgi?id=5505

           Summary: rsync 3.x reporting excluded files as error
           Product: rsync
           Version: 3.0.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: nhasan@nadmm.com
         QAContact: rsync-qa@samba.org


Since rsync 3.x, any daemon-excluded file is reported as error 23 (incomplete
transfer). This is incorrect and unlike the behaviour in previous versions. If
files are explicitly excluded by server config, then this is normal behaviour
for rsync to skip them.

The attached patch fixes this:

--- generator.c.old     2008-05-31 00:35:33.000000000 -0400
+++ generator.c 2008-05-31 00:35:55.000000000 -0400
@@ -1292,7 +1292,7 @@
                        if (F_IS_HLINKED(file))
                                handle_skipped_hlink(file, itemizing, code,
f_out);
 #endif
-                       rprintf(FERROR_XFER,
+                       rprintf(FINFO,
                                "skipping daemon-excluded %s
\"%s\"\n",
                                is_dir ? "directory" :
"file", fname);
                        if (is_dir)


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5505


matt@mattmccutchen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




------- Comment #1 from matt@mattmccutchen.net  2008-05-31 00:03 CST -------
No, it was the pre-3.0.0 behavior that was incorrect.  When a client tries to
push a file but is prevented from doing so by a daemon exclude, rsync has done
a transfer that is incorrect from the client's perspective, so it must issue
error 23.  To avoid the error, exclude the files on the client.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.