rsync - May 2008 - DO NOT REPLY [Bug 5474] New: extended attributes only copy if ACLs are copied on a Mac

https://bugzilla.samba.org/show_bug.cgi?id=5474

           Summary: extended attributes only copy if ACLs are copied on a
                    Mac
           Product: rsync
           Version: 3.0.3
          Platform: x86
        OS/Version: Other
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: psturdza@yahoo.com
         QAContact: rsync-qa@samba.org


Same issue as reported by Smokin Jake to the email list on 6 April still
happens with version 3.0.3pre2.
sudo rsync -avXH --fileflags --crtimes /Src/ /Dst/
does not copy extended attributes according to backup bouncer.  Adding -A to
the argument list does result in the extended attributes being copied.

This is on a 64-bit Intel Mac, if that matters:
rsync  version 3.0.3pre2  protocol version 30
Copyright (C) 1996-2008 by Andrew Tridgell, Wayne Davison, and others.
Web site: http://rsync.samba.org/
Capabilities:
    64-bit files, 32-bit inums, 32-bit timestamps, 64-bit long ints,
    socketpairs, hardlinks, symlinks, IPv6, batchfiles, inplace,
    append, ACLs, xattrs, iconv, symtimes, file-flags


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5474


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #1 from wayned@samba.org  2008-05-24 11:47 CST -------
A stock rsync works fine, but after applying the fileflags patch, the xattrs
test in the test suite starts to fail.  The reason for this is that the
get_xattrs() function has started to reject device and special files (due to a
buggy errno return from xattr functions), but the st_mode value in the stat
struct was not being set prior to the call in flist.c.

The fix is to add this line:

                        sx.st.st_mode = file->mode;

prior to the call of get_xattrs() in flist.c.  I'll make that fix in the git
repository.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.