rsync - Oct 2007 - DO NOT REPLY [Bug 5012] New: iconv: client charset used by server process

https://bugzilla.samba.org/show_bug.cgi?id=5012

           Summary: iconv: client charset used by server process
           Product: rsync
           Version: 3.0.0
          Platform: PPC
        OS/Version: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: kaarle@web.de
         QAContact: rsync-qa@samba.org


If rsync-3.0.0pre1 is called like

  rsync  --iconv=UTF-8-MAC,UTF-8 SOURCE HOST:DEST

the client charset, here UTF-8-MAC, is forwarded to the server process rather
than the specified destination charset UTF-8.  This is due a bug in
setup_iconv() where iconv_opt isn't truncated to the destination charset as
expected by server_options(...).


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5012





------- Comment #1 from kaarle@web.de  2007-10-07 12:07 CST -------
Created an attachment (id=2938)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2938&action=view)
truncate iconv_opt to target charset

Added patch to truncate iconv_opt to target charset after parsing.  I'm not
sure if it's save in any circumstances but it fixes this bug in the case
described above.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=5012


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned@samba.org  2007-10-07 15:46 CST -------
The problem came about due to my repositioning the setup_iconv() function too
early in the startup sequence.  I've moved it so that it gets called
appropriately for a client, a server, and a local-copy (where we fork a
"server").

Thanks for the report!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.