rsync - Aug 2007 - DO NOT REPLY [Bug 4904] New: POOL_INTERN ignored in pool_create()

https://bugzilla.samba.org/show_bug.cgi?id=4904

           Summary: POOL_INTERN ignored in pool_create()
           Product: rsync
           Version: 3.0.0
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: brion@wikimedia.org
         QAContact: rsync-qa@samba.org


While investigating a crash in pool_free_old(), I noticed another little buglet
in pool_create() -- the POOL_INTERN flag is checked against pool->flags
(which
is newly allocated and zeroed out) instead of the flags argument.

As a result, pool->size won't get adjusted, and POOL_APPEND doesn't
get added
into the flags, so extent structures get allocated separately. Since
POOL_INTERN is never checked for anywhere else, it ends up having no effect.

Switching the check from pool->flags to flags doesn't seem to have blown
anything up for me so far. :) One-line patch to be attached...


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4904





------- Comment #1 from brion@wikimedia.org  2007-08-20 16:25 CST -------
Created an attachment (id=2875)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2875&action=view)
Patch to lib/pool_alloc.c


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=4904


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Comment #2 from wayned@samba.org  2007-08-21 00:05 CST -------
Much appreciated.  I have committed your fix.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.