rsync - Jul 2006 - DO NOT REPLY [Bug 3935] New: replacing a full directory with symlink with --delete-after produces cryptic message

https://bugzilla.samba.org/show_bug.cgi?id=3935

           Summary: replacing a full directory with symlink with --delete-
                    after produces cryptic message
           Product: rsync
           Version: 2.6.6
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: core
        AssignedTo: wayned@samba.org
        ReportedBy: bugs.samba@docwhat.gerf.org
         QAContact: rsync-qa@samba.org


What Happned:
   On the source, a directory with files is changed to a symlink.
   rysnc -ra --delete-after will then generate the following message:
   rsync: delete_file: rmdir "/tmp/rsync.bug.11080/dest/somedir"
failed:
Directory not empty (39)
   rsync error: some files could not be transferred (code 23) at
   main.c(791)

What I Expected:
   I expected the directory to be replaced with a symlink (like
   --delete would have done)
   OR
   I expected the directory to be deleted at the end (because of
   --delete-after) but the symlink not to be sync'ed.  I would expect
   it to still raise an error, but the next run would fix it (since
   the directory is done).
   OR
   I expected the error message to explain how I could fix this
   problem.

I can see why it would fail during the sync phase, but the delete
phase should have deleted it after the syncing part, since no IO
errors were detected on the sending side.

I have attached a simple script to generate this error on command.

Ciao!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3935





------- Comment #1 from bugs.samba@docwhat.gerf.org  2006-07-14 10:25 MST
-------
Created an attachment (id=2034)
 --> (https://bugzilla.samba.org/attachment.cgi?id=2034&action=view)
A test case

This script will leave a /tmp/rsync.bug.NNNN directory around if it fails
(which it does in the current version of rsync).
You may want to clean up after the script before running it so that only one
directory hangs around.

Ciao!


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

https://bugzilla.samba.org/show_bug.cgi?id=3935


wayned@samba.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Version|2.6.6                       |2.6.7




------- Comment #2 from wayned@samba.org  2006-07-14 20:39 MST -------
Firstly, thanks for the detailed bug-report.  This bug was fixed in 2.6.7:

  - Got rid of the need for --force to be used in some circumstances with
    --delete-after (making it consistent with --delete-before/-during).

So, you can either upgrade to 2.6.8, or use the --force option when using
--delete-after.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.