Panagiotis Skintzos
2022-Jun-29 19:18 UTC
[Rd] Stack imbalance warnings while using the grid package, in R 4.2
On 29/6/22 17:18, Tomas Kalibera wrote:> > Thanks, yes, could you please send a patch for R-devel? So that it is > clear which PROTECTions you have in mind, and that they haven't been > fixed already in the meantime in R-devel (note that there have been > changes recently). > > It doesn't matter if you don't fix them all. > >> Hopefully this can be resolved for the next version. > > Sure, PROTECT errors have very high priority.Fantastic, thanks. Indeed most of them have been fixed in trunk. I attach a small patch (against revision 82535) that fixes the issue for the remaining functions (L_moveTo, L_lineTo, L_lines). With that applied, all tests in ggiraph pass without any warnings. Regards, Panagiotis -------------- next part -------------- A non-text attachment was scrubbed... Name: stack_imbalance.patch Type: text/x-patch Size: 600 bytes Desc: not available URL: <https://stat.ethz.ch/pipermail/r-devel/attachments/20220629/749a9c23/attachment.bin>
Paul Murrell
2022-Jun-29 21:09 UTC
[Rd] Stack imbalance warnings while using the grid package, in R 4.2
Hi Thanks very much for the report and the patch. I will take a look. Paul On 30/06/2022 7:18 am, Panagiotis Skintzos wrote:> > On 29/6/22 17:18, Tomas Kalibera wrote: >> >> Thanks, yes, could you please send a patch for R-devel? So that it is >> clear which PROTECTions you have in mind, and that they haven't been >> fixed already in the meantime in R-devel (note that there have been >> changes recently). >> >> It doesn't matter if you don't fix them all. >> >>> Hopefully this can be resolved for the next version. >> >> Sure, PROTECT errors have very high priority. > > Fantastic, thanks. > > > Indeed most of them have been fixed in trunk. > > I attach a small patch (against revision 82535) that fixes the issue for > the remaining functions (L_moveTo, L_lineTo, L_lines). > > With that applied, all tests in ggiraph pass without any warnings. > > > Regards, > > Panagiotis > > > > ______________________________________________ > R-devel at r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/r-devel-- Dr Paul Murrell Department of Statistics The University of Auckland Private Bag 92019 Auckland New Zealand 64 9 3737599 x85392 paul at stat.auckland.ac.nz http://www.stat.auckland.ac.nz/~paul/