Pkg xen devel - Dec 2020 - [PATCH 0/9] RESEND: Fixing cross-compilation, some script work

On Mon, Nov 30, 2020 at 09:46:17PM +0100, Hans van Kranenburg
wrote:
> On 11/27/20 1:43 AM, Elliott Mitchell wrote:
> > 17d192e0238d6c714e9f04593b59597b7090be38
> "tools/python: Pass linker to Python build process"
> 
> This one does not apply cleanly, but that's because of our make file
> patches. It's ok, since we would run into the same thing when moving to
> 4.15 anyway.
> 
> You might want to triple check what I have done here... After a few
> minutes, it's too easy to keep staring at it and not see some small
mistake.
Almost.  The modification of tools/pygrub/Makefile didn't split the line
on the build target.  My reasoning was it had already grown beyond 80
columns and had not been line-wrapped, so I left it as-is (likely someone
will line-wrap in the future).


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445

Hi,

On 12/1/20 3:58 AM, Elliott Mitchell wrote:
> On Mon, Nov 30, 2020 at 09:46:17PM +0100, Hans van Kranenburg wrote:
>> On 11/27/20 1:43 AM, Elliott Mitchell wrote:
>>> 17d192e0238d6c714e9f04593b59597b7090be38
>> "tools/python: Pass linker to Python build process"
>>
>> This one does not apply cleanly, but that's because of our make
file
>> patches. It's ok, since we would run into the same thing when
moving to
>> 4.15 anyway.
>>
>> You might want to triple check what I have done here... After a few
>> minutes, it's too easy to keep staring at it and not see some small
mistake.
> 
> Almost.
Almost what?
> The modification of tools/pygrub/Makefile didn't split the line
> on the build target.  My reasoning was it had already grown beyond 80
> columns and had not been line-wrapped, so I left it as-is (likely someone
> will line-wrap in the future).
Yes, you're adding new information and telling new thoughts, but all of
this does still not tell me if you spotted a mistake in my cherry-pick fix.

If you think there is one, point it out.

Hans