Ian Jackson
2019-Feb-12 17:29 UTC
[Pkg-xen-devel] [PATCH 09/13] xen init script: move init_dom0 into xenstored start
Hans van Kranenburg writes ("[PATCH 09/13] xen init script: move init_dom0 into xenstored start"):> This little xen-init-dom0 program is present in both our 4.8 and 4.11 > packages, so there's no need to keep the if else code. Also, it only > makes sense to run it after starting xenstored, and not all other times > start is called.I think xen-init-dom0 is not in jessie and although skip-upgrades are not "supported" I don't see a reason to gratuitously break them. Would you mind if we deferred removing this compat code until after buster ?> @@ -307,11 +299,6 @@ case "$1" in > 0|1) ;; > *) log_end_msg 1; exit ;; > esac > - init_dom0 > - case "$?" in > - 0|1) ;; > - *) log_end_msg 1; exit ;; > - esacIt would have been less confusing to me if you had separated out the change to remove the open-coded fallback, from the change to when this is called. Also the latter change seems right and here I am complaining about the former... Thanks, Ian. -- Ian Jackson <ijackson at chiark.greenend.org.uk> These opinions are my own. If I emailed you from an address @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.
Hans van Kranenburg
2019-Feb-12 18:08 UTC
[Pkg-xen-devel] [PATCH 09/13] xen init script: move init_dom0 into xenstored start
On 2/12/19 6:29 PM, Ian Jackson wrote:> Hans van Kranenburg writes ("[PATCH 09/13] xen init script: move init_dom0 into xenstored start"): >> This little xen-init-dom0 program is present in both our 4.8 and 4.11 >> packages, so there's no need to keep the if else code. Also, it only >> makes sense to run it after starting xenstored, and not all other times >> start is called. > > I think xen-init-dom0 is not in jessie and although skip-upgrades are > not "supported" I don't see a reason to gratuitously break them. > Would you mind if we deferred removing this compat code until after > buster ?Sure. I was under the impression that "skip-upgrades" were explicitly unsupported in Debian, and if you do it and it breaks, you just keep the pieces.>> @@ -307,11 +299,6 @@ case "$1" in >> 0|1) ;; >> *) log_end_msg 1; exit ;; >> esac >> - init_dom0 >> - case "$?" in >> - 0|1) ;; >> - *) log_end_msg 1; exit ;; >> - esac > > It would have been less confusing to me if you had separated out the > change to remove the open-coded fallback, from the change to when this > is called.Yes, that's better.> Also the latter change seems right and here I am complaining about > the former...:) K
Ian Jackson
2019-Feb-12 18:19 UTC
[Pkg-xen-devel] [PATCH 09/13] xen init script: move init_dom0 into xenstored start
Hans van Kranenburg writes ("Re: [PATCH 09/13] xen init script: move init_dom0 into xenstored start"):> On 2/12/19 6:29 PM, Ian Jackson wrote: > > I think xen-init-dom0 is not in jessie and although skip-upgrades are > > not "supported" I don't see a reason to gratuitously break them. > > Would you mind if we deferred removing this compat code until after > > buster ? > > Sure. I was under the impression that "skip-upgrades" were explicitly > unsupported in Debian, and if you do it and it breaks, you just keep the > pieces.Sure. But I have done it myself a number of times. I didn't file bugs about the things that went wrong but I appreciated that most maintainers don't strip this kind of stuff out over-vigorously. Ian. -- Ian Jackson <ijackson at chiark.greenend.org.uk> These opinions are my own. If I emailed you from an address @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.