Pkg xen devel - Feb 2006 - Do we have one make more than necessary?

Hi, I was noticing that our debian/rules did:

...
debian/stamps/build:
        mkdir -p $(@D)
        rm -rf debian/install
        $(MAKE) all DESTDIR=$(CURDIR)/debian/install KERNELS= GCC=$(CC) CC=$(CC)
HOSTCC=$(CC)
        touch $@

install: debian/stamps/build
        rm -rf debian/install
        $(MAKE) dist DESTDIR=$(CURDIR)/debian/install KERNELS=
XEN_PYTHON_NATIVE_INSTALL=1 CC=$(CC) GCC=$(CC) HOSTCC=$(CC) XEN_CHANGESET=8743
ifeq ($(DEB_BUILD_ARCH),i386)
        $(MAKE) mrproper
        $(MAKE) xen DESTDIR=$(CURDIR)/debian/install KERNELS= GCC=$(CC) CC=$(CC)
HOSTCC=$(CC) XEN_TARGET_X86_PAE=y TARGET=$(CURDIR)/xen/xen_pae
XEN_CHANGESET=8743
endif
        $(MAKE) -C tools/examples install-udev DESTDIR=$(CURDIR)/debian/install
...


Doesn't then install make three times (one in its debian/stamps/build
dependency and the other two in install?) Aren't two of them sufficient (one
for everything and the other one just for the pae, on i386)

Thanks,

Guido

I am not sure... I haven't changed that from adam's version, but I guess
that
the "make all" call just builds everything and "make dist"
installs it then.
(So it matches the build & install target of our rules file).

In that case we should be able to remove the "make all" call and just
use
"make dist" because make dist will build and install everything then.
But
which section of our rules file is the correct place then? "build:" or
"install:" ? :)

But by doing this, we would have only one make call (+ for i386 the make 
mrproper and make xen call). If this is all we really need we should do this, 
because it keeps the rules file simple :)

As said I have to check the pae thing tomorrow. I can build the testing 
packages with just one "make dist" call (+ of course the pae stuff)
and also
test that, so we know if we can safely remove the useless "make all"
call.

--Ralph

Am Sonntag, 19. Februar 2006 22:55 schrieb Guido
Trotter:
> Hi, I was noticing that our debian/rules did:
>
> ...
> debian/stamps/build:
>         mkdir -p $(@D)
>         rm -rf debian/install
>         $(MAKE) all DESTDIR=$(CURDIR)/debian/install KERNELS= GCC=$(CC)
> CC=$(CC) HOSTCC=$(CC) touch $@
>
> install: debian/stamps/build
>         rm -rf debian/install
>         $(MAKE) dist DESTDIR=$(CURDIR)/debian/install KERNELS>
XEN_PYTHON_NATIVE_INSTALL=1 CC=$(CC) GCC=$(CC) HOSTCC=$(CC)
> XEN_CHANGESET=8743 ifeq ($(DEB_BUILD_ARCH),i386)
>         $(MAKE) mrproper
>         $(MAKE) xen DESTDIR=$(CURDIR)/debian/install KERNELS= GCC=$(CC)
> CC=$(CC) HOSTCC=$(CC) XEN_TARGET_X86_PAE=y TARGET=$(CURDIR)/xen/xen_pae
> XEN_CHANGESET=8743 endif
>         $(MAKE) -C tools/examples install-udev
> DESTDIR=$(CURDIR)/debian/install ...
>
>
> Doesn't then install make three times (one in its debian/stamps/build
> dependency and the other two in install?) Aren't two of them sufficient
> (one for everything and the other one just for the pae, on i386)
>
> Thanks,
>
> Guido
>
>
> _______________________________________________
> Pkg-xen-devel mailing list
> Pkg-xen-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-xen-devel